From: Larry Finger <Larry.Finger@lwfinger.net>
To: Joe Perches <joe@perches.com>
Cc: Andrew Miller <amiller@amilx.com>,
gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: rtl8187se: r8180_core.c: Fix coding style issue
Date: Tue, 13 Mar 2012 22:09:39 -0500 [thread overview]
Message-ID: <4F600BF3.2080001@lwfinger.net> (raw)
In-Reply-To: <1331693187.27389.33.camel@joe2Laptop>
On 03/13/2012 09:46 PM, Joe Perches wrote:
> On Tue, 2012-03-13 at 22:33 -0400, Andrew Miller wrote:
>> Thanks, you help me alot
>>
>> If you don't mind me asking a few more question.
>>
>> Would fixing things like this
>>
>> - if(x==y)
>> + if(x == y)
>>
>> be worthless?
>
> I don't work on staging code.
>
> I believe the staging rtl8187se directory could be
> deleted as there is a working mainline directory
> for the 8187 (drivers/net/wireless/rtl818x/rtl8187)
> so you may not actually be adding anything of value.
>
> I don't know if the 8187se is supported by the 8187
> code but likely Larry Finger (cc'd) knows better.
Driver rtl8187 handles USB devices - the RTL8187SE is PCI based - thus separate
drivers are needed. I have done a lot of the conversion of a mac80211-based
driver for the RTL8187SE, but ran into a problem where it could transmit small
packets, but fail completely for longer ones. While trying to fix that, I needed
to work on devices that had no Linux driver, and I have not gotten back to it.
Larry
next prev parent reply other threads:[~2012-03-14 3:09 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-14 0:58 [PATCH] Staging: rtl8187se: r8180_core.c: Fix coding style issue Andrew Miller
2012-03-14 1:33 ` Joe Perches
2012-03-14 1:49 ` Andrew Miller
2012-03-14 2:12 ` Joe Perches
2012-03-14 2:33 ` Andrew Miller
2012-03-14 2:46 ` Joe Perches
2012-03-14 3:09 ` Larry Finger [this message]
2012-03-14 2:54 ` Greg KH
2012-03-14 4:18 ` Ryan Mallon
2012-03-14 4:49 ` Joe Perches
-- strict thread matches above, loose matches on Subject: below --
2012-03-11 4:32 Andrew Miller
2012-03-13 22:42 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F600BF3.2080001@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=amiller@amilx.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox