From: Ulrich Drepper <drepper@akkadia.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: arnd@arndb.de, davem@davemloft.net, hverkuil@xs4all.nl,
laurent.pinchart@ideasonboard.com, linux-kernel@vger.kernel.org,
mchehab@redhat.com
Subject: Re: [PATCH] Install kernel-page-flags.h
Date: Wed, 14 Mar 2012 04:03:52 -0400 [thread overview]
Message-ID: <4F6050E8.1060100@akkadia.org> (raw)
In-Reply-To: <20120314075842.GA337@infradead.org>
On 03/14/2012 03:58 AM, Christoph Hellwig wrote:
> I don't think this is a good idea at all. Let's shoot the person who
> added that braindead interface ASAP, and replace it with one printing
> the flags in ASCII format.
This isn't really realistic. The information is retrieved based on the
PFN using lseek+read from a file descriptor. How is the read supposed
to work in case the record returned is not of a fixed size? Aside,
potentially a lot of these records are to be read and using ASCII
strings will significantly slow things down.
If you have a concrete proposal please go ahead and propose it.
next prev parent reply other threads:[~2012-03-14 9:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-14 7:26 [PATCH] Install kernel-page-flags.h Ulrich Drepper
2012-03-14 7:58 ` Christoph Hellwig
2012-03-14 8:03 ` Ulrich Drepper [this message]
2012-03-14 10:40 ` Alexey Dobriyan
2012-03-19 11:32 ` Christoph Hellwig
2012-03-19 12:45 ` Alexey Dobriyan
2012-03-25 12:28 ` Ulrich Drepper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F6050E8.1060100@akkadia.org \
--to=drepper@akkadia.org \
--cc=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=hch@infradead.org \
--cc=hverkuil@xs4all.nl \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox