From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1031475Ab2COBCn (ORCPT ); Wed, 14 Mar 2012 21:02:43 -0400 Received: from plane.gmane.org ([80.91.229.3]:46180 "EHLO plane.gmane.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1031451Ab2COBCi (ORCPT ); Wed, 14 Mar 2012 21:02:38 -0400 X-Injected-Via-Gmane: http://gmane.org/ To: linux-kernel@vger.kernel.org From: Namhyung Kim Subject: Re: [PATCH] perf: Add a new sort order: SORT_INCLUSIVE (v4) Date: Thu, 15 Mar 2012 10:02:23 +0900 Message-ID: <4F613F9F.6060700@lge.com> References: <1331746607-6706-1-git-send-email-asharma@fb.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Complaints-To: usenet@dough.gmane.org X-Gmane-NNTP-Posting-Host: 121.50.20.41 User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:10.0.2) Gecko/20120216 Thunderbird/10.0.2 In-Reply-To: <1331746607-6706-1-git-send-email-asharma@fb.com> Cc: linux-perf-users@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2012-03-15 2:36 AM, Arun Sharma wrote: > Each entry that used to get added once to the histogram, now is added > chain->nr times, each time with one less entry in the > callchain. > > This will result in a non-leaf function that appears in a lot of > samples to get a histogram entry with lots of hits. > > The user can then drill down into the callchains of functions that > have high inclusive times. > > Sample command lines: > > $ perf record -ag -- sleep 1 > $ perf report -g graph,0.5,callee -n -s inclusive > Reviewed-by: Namhyung Kim Thanks, looks good to me now - although I still prefer make it a switch to alter the behavior of the existing "symbol" sort order to do "inclusive" calculation of its periods, but I can live with this :). > Signed-off-by: Arun Sharma > Cc: Ingo Molnar > CC: Arnaldo Carvalho de Melo > Cc: Frederic Weisbecker > Cc: Mike Galbraith > Cc: Paul Mackerras > Cc: Peter Zijlstra > Cc: Stephane Eranian > Cc: Namhyung Kim > Cc: Tom Zanussi > Cc: linux-kernel@vger.kernel.org > Cc: linux-perf-users@vger.kernel.org > --- > tools/perf/builtin-annotate.c | 2 +- > tools/perf/builtin-diff.c | 2 +- > tools/perf/builtin-report.c | 13 +++---- > tools/perf/builtin-top.c | 2 +- > tools/perf/util/callchain.c | 15 ++++++++ > tools/perf/util/callchain.h | 4 ++ > tools/perf/util/hist.c | 80 +++++++++++++++++++++++++++++++++++++++- > tools/perf/util/hist.h | 4 ++- > tools/perf/util/sort.c | 14 +++++++ > tools/perf/util/sort.h | 4 ++ > 10 files changed, 126 insertions(+), 14 deletions(-) >