From: Sergei Shtylyov <sshtylyov@mvista.com>
To: Yongsul@vger.kernel.org, Oh@vger.kernel.org
Cc: Felipe Balbi <balbi@ti.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
"yongsul96.oh@samsung.com" <yongsul96.oh@samsung.com>
Subject: Re: [PATCH] USB: Gadget: Composite: Added error handling codes to prevent a memory leak case when the configuration's bind function failed
Date: Thu, 15 Mar 2012 17:57:40 +0400 [thread overview]
Message-ID: <4F61F554.1010302@mvista.com> (raw)
In-Reply-To: <1331774635-21217-1-git-send-email-yongsul96.oh@samsung.com>
Hello.
On 15-03-2012 5:23, Yongsul@vger.kernel.org wrote:
> From: yongsul96.oh@samsung.com<yongsul96.oh@samsung.com>
> In some usb gadget driver, for example usb gadget serial driver(serial.c),
> multifunction composite driver(multi,c), nokia composite gadget driver(nokia.c),
> HID composite driver(hid.c), CDC composite driver(cdc2.c).., the configuration's
> bind function by called the 'usb_add_config()' has multiple bind config functions
> for each functionality, for example cdc2 configuration bind function -'cdc_do_config()'
> has two functionality bind config functions -'ecm_bind_config()'& 'acm_bind_config()'
> in CDC composite driver.
> In each functionality bind config function, new instance for each functionality is
> allocated& initialized by 'kzalloc()' ,and finally the new instance is added by
> 'usb_add_function()'. After 'usb_add_function' state, already created the instance
> is only handled by its configuration& freed from functionality unbind function.
> So, If an error occurred during the second functionality bind config state, for example
> an error occurred at 'acm_bind_config()' after succeeding 'ecm_bind_function()',
> The created instance by 'acm_bind_config()' cannot be freed.
> And it makes memory leak situation.
> This patch fixes this issue.
> Signed-off-by: yongsul96.oh@samsung.com <yongsul96.oh@samsung.com>
Real name is required on the left, not another copy of email.
WBR, Sergei
next prev parent reply other threads:[~2012-03-15 13:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-15 1:23 [PATCH] USB: Gadget: Composite: Added error handling codes to prevent a memory leak case when the configuration's bind function failed Yongsul, Oh
2012-03-15 8:19 ` Michal Nazarewicz
2012-03-15 13:57 ` Sergei Shtylyov [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-03-16 6:27 Yongsul Oh
2012-03-16 11:14 ` Michal Nazarewicz
2012-03-19 8:34 ` Yongsul Oh
2012-03-20 1:38 Yongsul Oh
2012-03-20 13:41 ` Michal Nazarewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F61F554.1010302@mvista.com \
--to=sshtylyov@mvista.com \
--cc=Oh@vger.kernel.org \
--cc=Yongsul@vger.kernel.org \
--cc=balbi@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=yongsul96.oh@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox