From: Karol Lewandowski <k.lewandowsk@samsung.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: ben-linux@fluff.org, thomas.abraham@linaro.org,
m.szyprowski@samsung.com, linux-kernel@vger.kernel.org,
linux-i2c@vger.kernel.org, devicetree-discuss@lists.ozlabs.org,
linux-samsung-soc@vger.kernel.org, t.stanislaws@samsung.com,
Kyungmin Park <kyungmin.park@samsung.com>
Subject: Re: [PATCH 2/3] i2c-s3c2410: Rework device type handling
Date: Thu, 15 Mar 2012 17:54:33 +0100 [thread overview]
Message-ID: <4F621EC9.6020106@samsung.com> (raw)
In-Reply-To: <20120315125630.GK3138@opensource.wolfsonmicro.com>
On 15.03.2012 13:56, Mark Brown wrote:
> On Thu, Mar 15, 2012 at 11:04:56AM +0100, Karol Lewandowski wrote:
>
>> Introducing separate type (TYPE_S3C2440_HDMIPHY) has been our original
>> attempt to solve this issue. However, this required adding explicit
>> checks to driver code all over the place (if (type == S3C2400 ||
>> type == S3c2440_HDMIPHY).
>
> Another option is to change the type to be a pointer to a struct with
> quirk flags in it.
Sure, that's possible. However, I don't find it any simpler than
using bitmasks. Quite to contrary - I consider it redundant to
bring new structure into existence when simple uint does the trick
just fine (IMHO, of course).
If you consider code to be inherently less readable because of this
approach I'll rework it. If it's not a such big deal for you I would
prefer to keep it as is.
Thanks!
--
Karol Lewandowski | Samsung Poland R&D Center | Linux/Platform
next prev parent reply other threads:[~2012-03-15 16:54 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-13 16:54 [PATCH 0/3 v2] Updates for exynos4210 and DT-based systems Karol Lewandowski
2012-03-13 16:54 ` [PATCH 1/3] i2c-s3c2410: Drop unused define Karol Lewandowski
2012-03-18 20:49 ` Grant Likely
2012-03-13 16:54 ` [PATCH 2/3] i2c-s3c2410: Rework device type handling Karol Lewandowski
2012-03-14 17:29 ` Mark Brown
2012-03-15 10:04 ` Karol Lewandowski
2012-03-15 12:56 ` Mark Brown
2012-03-15 16:54 ` Karol Lewandowski [this message]
2012-03-19 19:55 ` Mark Brown
2012-03-21 10:33 ` Karol Lewandowski
2012-03-21 11:50 ` Mark Brown
2012-03-21 11:54 ` Karol Lewandowski
2012-03-13 16:54 ` [PATCH 3/3] i2c-s3c2410: Add HDMIPHY quirk for S3C2440 Karol Lewandowski
2012-03-13 17:27 ` Tomasz Stanislawski
2012-03-13 18:00 ` Karol Lewandowski
2012-03-13 18:13 ` [PATCH] " Karol Lewandowski
2012-03-14 1:49 ` [PATCH 0/3 v2] Updates for exynos4210 and DT-based systems Kyungmin Park
-- strict thread matches above, loose matches on Subject: below --
2012-03-21 19:11 [PATCH v3 0/3] i2c-s3c2410: " Karol Lewandowski
2012-03-21 19:11 ` [PATCH 2/3] i2c-s3c2410: Rework device type handling Karol Lewandowski
2012-03-21 20:30 ` Mark Brown
2012-04-17 17:31 ` Wolfram Sang
2012-04-18 11:55 ` Karol Lewandowski
2012-04-18 13:39 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F621EC9.6020106@samsung.com \
--to=k.lewandowsk@samsung.com \
--cc=ben-linux@fluff.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=kyungmin.park@samsung.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=t.stanislaws@samsung.com \
--cc=thomas.abraham@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox