From: Martyn Welch <martyn.welch@ge.com>
To: Gerard Snitselaar <dev@snitselaar.org>
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: vme: fix section mismatches in linux-next 20120314
Date: Fri, 16 Mar 2012 10:43:31 +0000 [thread overview]
Message-ID: <4F631953.1090701@ge.com> (raw)
In-Reply-To: <1331801439-30038-1-git-send-email-dev@snitselaar.org>
On 15/03/12 08:50, Gerard Snitselaar wrote:
> pio2_gpio_init() annotated with __init, but called by pio2_probe()
> which is annotated __devinit. pio2_gpio_exit() is annotated __exit,
> but is called by pio2_probe() and by pio2_remove() which is annotated
> __devexit.
>
> Signed-off-by: Gerard Snitselaar <dev@snitselaar.org>
I was just about to ack that and realised that Greg's already applied it :-)
Good catch, thanks,
Martyn
> ---
> drivers/staging/vme/devices/vme_pio2.h | 4 ++--
> drivers/staging/vme/devices/vme_pio2_gpio.c | 4 ++--
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/vme/devices/vme_pio2.h b/drivers/staging/vme/devices/vme_pio2.h
> index 3c59313..72d9ce0 100644
> --- a/drivers/staging/vme/devices/vme_pio2.h
> +++ b/drivers/staging/vme/devices/vme_pio2.h
> @@ -243,7 +243,7 @@ struct pio2_card {
> int pio2_cntr_reset(struct pio2_card *);
>
> int pio2_gpio_reset(struct pio2_card *);
> -int __init pio2_gpio_init(struct pio2_card *);
> -void __exit pio2_gpio_exit(struct pio2_card *);
> +int __devinit pio2_gpio_init(struct pio2_card *);
> +void pio2_gpio_exit(struct pio2_card *);
>
> #endif /* _VME_PIO2_H_ */
> diff --git a/drivers/staging/vme/devices/vme_pio2_gpio.c b/drivers/staging/vme/devices/vme_pio2_gpio.c
> index dc837de..8584849 100644
> --- a/drivers/staging/vme/devices/vme_pio2_gpio.c
> +++ b/drivers/staging/vme/devices/vme_pio2_gpio.c
> @@ -187,7 +187,7 @@ int pio2_gpio_reset(struct pio2_card *card)
> return 0;
> }
>
> -int __init pio2_gpio_init(struct pio2_card *card)
> +int __devinit pio2_gpio_init(struct pio2_card *card)
> {
> int retval = 0;
> char *label;
> @@ -220,7 +220,7 @@ int __init pio2_gpio_init(struct pio2_card *card)
> return retval;
> };
>
> -void __exit pio2_gpio_exit(struct pio2_card *card)
> +void pio2_gpio_exit(struct pio2_card *card)
> {
> const char *label = card->gc.label;
>
--
Martyn Welch (Lead Software Engineer) | Registered in England and Wales
GE Intelligent Platforms | (3828642) at 100 Barbirolli Square
T +44(0)1327322748 | Manchester, M2 3AB
E martyn.welch@ge.com | VAT:GB 927559189
prev parent reply other threads:[~2012-03-16 10:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-15 8:50 [PATCH] staging: vme: fix section mismatches in linux-next 20120314 Gerard Snitselaar
2012-03-16 10:43 ` Martyn Welch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F631953.1090701@ge.com \
--to=martyn.welch@ge.com \
--cc=dev@snitselaar.org \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox