From: Jason Wessel <jason.wessel@windriver.com>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: <linux-kernel@vger.kernel.org>, <kgdb-bugreport@lists.sourceforge.net>
Subject: Re: [PATCH 3/4] kgdb: Respect that flush op is optional
Date: Fri, 16 Mar 2012 07:46:38 -0500 [thread overview]
Message-ID: <4F63362E.1090701@windriver.com> (raw)
In-Reply-To: <08ddbfb8fbca5fef8adfce3449b5744b0db7b45f.1331900215.git.jan.kiszka@siemens.com>
On 03/16/2012 07:17 AM, Jan Kiszka wrote:
> Not all kgdb I/O drivers implement a flush operation. Adjust
> gdbstub_exit accordingly.
The flush is certainly optional. The reason we never saw this bug is because it was only used by some code not in the mainline, where it is in fact patched. The out of tree patch hooked into the reboot notifier.
It makes me wonder if using the reboot notifier is enough vs the call backs you placed in the critical power off points in your patch [4/4]. I'll respond separately to that thread because there are other folks in the CC line.
If we decide to roll with this series, I will definitely merge this patch, else I will remove the code since it is not used except for out of tree patches.
Thanks,
Jason.
next prev parent reply other threads:[~2012-03-16 12:46 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-16 12:17 [PATCH 0/4] kgdb: Small usability improvements for x86 Jan Kiszka
2012-03-16 12:17 ` [PATCH 1/4] kgdb: x86: Return all segment registers also in 64-bit mode Jan Kiszka
2012-03-16 15:57 ` Jason Wessel
2012-03-19 13:52 ` Jan Kiszka
2012-03-19 20:52 ` Jason Wessel
2012-03-16 12:17 ` [PATCH 2/4] kgdb: Make gdbstub_exit a nop unless gdb is attached Jan Kiszka
2012-03-16 16:04 ` Jason Wessel
2012-03-16 12:17 ` [PATCH 3/4] kgdb: Respect that flush op is optional Jan Kiszka
2012-03-16 12:46 ` Jason Wessel [this message]
2012-03-16 12:53 ` Jan Kiszka
2012-03-16 16:16 ` Jason Wessel
2012-03-16 12:17 ` [PATCH 4/4] kgdb: x86: Detach gdb if machine shuts down or reboots Jan Kiszka
2012-03-16 15:36 ` Jason Wessel
2012-03-19 13:49 ` Jan Kiszka
2012-03-20 1:00 ` Jason Wessel
2012-03-20 11:18 ` [Kgdb-bugreport] " Sergei Shtylyov
2012-03-20 11:46 ` Jason Wessel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F63362E.1090701@windriver.com \
--to=jason.wessel@windriver.com \
--cc=jan.kiszka@siemens.com \
--cc=kgdb-bugreport@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox