From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760812Ab2CPQEA (ORCPT ); Fri, 16 Mar 2012 12:04:00 -0400 Received: from mail3.caviumnetworks.com ([12.108.191.235]:18979 "EHLO mail3.caviumnetworks.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757326Ab2CPQD6 (ORCPT ); Fri, 16 Mar 2012 12:03:58 -0400 Message-ID: <4F63646D.1040700@cavium.com> Date: Fri, 16 Mar 2012 09:03:57 -0700 From: David Daney User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.15) Gecko/20101027 Fedora/3.0.10-1.fc12 Thunderbird/3.0.10 MIME-Version: 1.0 To: Joe Perches CC: "Theodore Ts'o" , Andreas Dilger , linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/9] ext4: Add -DDEBUG to Makefile References: <7ee60f3b750f4500f9bdcb64f358acbf17987036.1331856300.git.joe@perches.com> In-Reply-To: <7ee60f3b750f4500f9bdcb64f358acbf17987036.1331856300.git.joe@perches.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-OriginalArrivalTime: 16 Mar 2012 16:03:50.0039 (UTC) FILETIME=[605A6A70:01CD038E] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/15/2012 05:07 PM, Joe Perches wrote: > Add -DDEBUG to enable future use of pr_debug. > No changes to objects as no DEBUG uses currently exist. > > Signed-off-by: Joe Perches > --- > fs/ext4/Makefile | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/fs/ext4/Makefile b/fs/ext4/Makefile > index 56fd8f86..617a5d8 100644 > --- a/fs/ext4/Makefile > +++ b/fs/ext4/Makefile > @@ -2,6 +2,8 @@ > # Makefile for the linux ext4-filesystem routines. > # > > +ccflags-$(CONFIG_EXT4_FS) := -DDEBUG In many other susbsystems/drivers, the definition of DEBUG is gated by a separate Kconfig symbol used to select debugging just for that susbsystem/driver (see CONFIG_MMC_DEBUG for example). Why aren't you doing the same here? David Daney