public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Srivatsa S. Bhat" <srivatsa.bhat@linux.vnet.ibm.com>
To: Steven Rostedt <rostedt@goodmis.org>, "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: "mingo@elte.hu" <mingo@elte.hu>, "pavel@ucw.cz" <pavel@ucw.cz>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Linux PM mailing list <linux-pm@vger.kernel.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	"Srivatsa S. Bhat" <srivatsa.bhat@linux.vnet.ibm.com>
Subject: Suspend-to-ram not working when ftrace is enabled, again!
Date: Mon, 19 Mar 2012 21:16:34 +0530	[thread overview]
Message-ID: <4F6754DA.6090401@linux.vnet.ibm.com> (raw)

Hi,

If tracing is enabled and we are tracing low-level suspend-to-ram related
functions like restore_processor_state() etc (which are included by default
in the list of traced functions), and we try suspending the machine, the
machine doesn't resume. It reboots instead.
(If we trace some unrelated functions like kzalloc() for example, there is
no problem with suspend/resume).

Looking at https://lkml.org/lkml/2008/8/27/177, it appears that this
is an old problem and also had a workaround (disabling tracing around
suspend). The above patch corresponds to commit id: f42ac38c59 (ftrace:
disable tracing for suspend to ram), which went in around 2.6.27 I think.
But then commit cbe2f5a6e84 (tracing: allow tracing of suspend/resume &
hibernation code again) reverted that commit.

And from https://lkml.org/lkml/2008/8/21/349, it looks like 2.6.28 and
further was supposed to be problem-free. But unfortunately this problem has
resurfaced.

I tested kernel 2.6.32.54 and I observed that the machine reboots during
resume, which looks exactly like the problem discussed in the link above.

In another machine, I tested 3.3-rc6 and it doesn't seem to respond to
resume events (like button press, lid open) at all. It just seems to remain
suspended forever.

Should we resort to disabling ftrace around suspend again? Or do we have a
better solution this time around?

Regards,
Srivatsa S. Bhat


             reply	other threads:[~2012-03-19 15:46 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-19 15:46 Srivatsa S. Bhat [this message]
2012-03-20 13:42 ` Suspend-to-ram not working when ftrace is enabled, again! Steven Rostedt
2012-03-20 13:57   ` Srivatsa S. Bhat

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F6754DA.6090401@linux.vnet.ibm.com \
    --to=srivatsa.bhat@linux.vnet.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=pavel@ucw.cz \
    --cc=rjw@sisk.pl \
    --cc=rostedt@goodmis.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox