From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760403Ab2CTOnU (ORCPT ); Tue, 20 Mar 2012 10:43:20 -0400 Received: from [89.21.227.130] ([89.21.227.130]:57761 "EHLO mail.epsilon.itdev.co.uk" rhost-flags-FAIL-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1760385Ab2CTOnR (ORCPT ); Tue, 20 Mar 2012 10:43:17 -0400 Message-ID: <4F689782.3000902@itdev.co.uk> Date: Tue, 20 Mar 2012 07:43:14 -0700 From: Nick Dyer User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.2) Gecko/20120216 Thunderbird/10.0.2 MIME-Version: 1.0 To: Daniel Kurtz CC: Dmitry Torokhov , Joonyoung Shim , Iiro Valkonen , Henrik Rydberg , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Benson Leung , Yufeng Shen Subject: Re: [PATCH 05/20] Input: atmel_mxt_ts - dump mxt_read/write_reg References: <1331640263-18935-1-git-send-email-djkurtz@chromium.org> <1331640263-18935-6-git-send-email-djkurtz@chromium.org> In-Reply-To: <1331640263-18935-6-git-send-email-djkurtz@chromium.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Daniel Kurtz wrote: > For verbose on-the-wire debugging. > Prints DUMP_LEN bytes (in hex) per line. > > Signed-off-by: Daniel Kurtz I don't think this belongs in the driver. If you want low level i2c transfer dumps, it should go in i2c subsystem. Plus, there is the print_hex_dump function for hex dumps. cheers -- Nick Dyer Software Engineer, ITDev Ltd Hardware and Software Development Consultancy Website: http://www.itdev.co.uk