From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759987Ab2CUShw (ORCPT ); Wed, 21 Mar 2012 14:37:52 -0400 Received: from mailout-de.gmx.net ([213.165.64.23]:44497 "HELO mailout-de.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1759882Ab2CUShu (ORCPT ); Wed, 21 Mar 2012 14:37:50 -0400 X-Authenticated: #10250065 X-Provags-ID: V01U2FsdGVkX1+VYmxtC9WVWm2oR3aLXe62DkbUC/4c7/EA19SRbv bmhZsq60x3QeKJ Message-ID: <4F6A1FE0.8040808@gmx.de> Date: Wed, 21 Mar 2012 18:37:20 +0000 From: Florian Tobias Schandinat User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.16) Gecko/20120207 Icedove/3.0.11 MIME-Version: 1.0 To: Julia Lawall CC: kernel-janitors@vger.kernel.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/7] drivers/video/pvr2fb.c: ensure arguments to request_irq and free_irq are compatible References: <1331494587-12196-1-git-send-email-Julia.Lawall@lip6.fr> <1331494587-12196-2-git-send-email-Julia.Lawall@lip6.fr> In-Reply-To: <1331494587-12196-2-git-send-email-Julia.Lawall@lip6.fr> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Y-GMX-Trusted: 0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/11/2012 07:36 PM, Julia Lawall wrote: > From: Julia Lawall > > Convert calls to free_irq so that the second argument is the same as the > last argument of the corresponding call to request_irq. Without this > property, free_irq does nothing. > > Signed-off-by: Julia Lawall Applied. Thanks, Florian Tobias Schandinat > > --- > Not tested. > > drivers/video/pvr2fb.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/video/pvr2fb.c b/drivers/video/pvr2fb.c > index 3a3fdc6..bcd44c3 100644 > --- a/drivers/video/pvr2fb.c > +++ b/drivers/video/pvr2fb.c > @@ -895,7 +895,7 @@ static int __init pvr2fb_dc_init(void) > > #ifdef CONFIG_PVR2_DMA > if (request_dma(pvr2dma, "pvr2") != 0) { > - free_irq(HW_EVENT_VSYNC, 0); > + free_irq(HW_EVENT_VSYNC, fb_info); > return -EBUSY; > } > #endif > @@ -914,7 +914,7 @@ static void __exit pvr2fb_dc_exit(void) > currentpar->mmio_base = 0; > } > > - free_irq(HW_EVENT_VSYNC, 0); > + free_irq(HW_EVENT_VSYNC, fb_info); > #ifdef CONFIG_PVR2_DMA > free_dma(pvr2dma); > #endif > >