From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030847Ab2CVGI0 (ORCPT ); Thu, 22 Mar 2012 02:08:26 -0400 Received: from mail-qa0-f53.google.com ([209.85.216.53]:36323 "EHLO mail-qa0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030452Ab2CVGIX (ORCPT ); Thu, 22 Mar 2012 02:08:23 -0400 Message-ID: <4F6AC1D4.1090602@kernel.org> Date: Thu, 22 Mar 2012 02:08:20 -0400 From: Len Brown User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.22) Gecko/20110906 Fedora/3.1.14-1.fc14 Lightning/1.0b3pre Thunderbird/3.1.14 MIME-Version: 1.0 To: Andi Kleen CC: linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, mjg@redhat.com, Andi Kleen Subject: Re: [PATCH 1/5] ACPI: ec: Do request_region outside WARN() References: <1328545032-21373-1-git-send-email-andi@firstfloor.org> <1328545032-21373-2-git-send-email-andi@firstfloor.org> In-Reply-To: <1328545032-21373-2-git-send-email-andi@firstfloor.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Applied. thanks, Len Brown, Intel Open Source Technology Center On 02/06/2012 11:17 AM, Andi Kleen wrote: > WARN() is not supposed to have side effects, so move the request_regions > outside. > > Signed-off-by: Andi Kleen > --- > drivers/acpi/ec.c | 8 ++++---- > 1 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/acpi/ec.c b/drivers/acpi/ec.c > index b19a18d..3268dcf 100644 > --- a/drivers/acpi/ec.c > +++ b/drivers/acpi/ec.c > @@ -812,10 +812,10 @@ static int acpi_ec_add(struct acpi_device *device) > first_ec = ec; > device->driver_data = ec; > > - WARN(!request_region(ec->data_addr, 1, "EC data"), > - "Could not request EC data io port 0x%lx", ec->data_addr); > - WARN(!request_region(ec->command_addr, 1, "EC cmd"), > - "Could not request EC cmd io port 0x%lx", ec->command_addr); > + ret = !!request_region(ec->data_addr, 1, "EC data"); > + WARN(!ret, "Could not request EC data io port 0x%lx", ec->data_addr); > + ret = !!request_region(ec->command_addr, 1, "EC cmd"); > + WARN(!ret, "Could not request EC cmd io port 0x%lx", ec->command_addr); > > pr_info(PREFIX "GPE = 0x%lx, I/O: command/status = 0x%lx, data = 0x%lx\n", > ec->gpe, ec->command_addr, ec->data_addr);