From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758388Ab2CVQJu (ORCPT ); Thu, 22 Mar 2012 12:09:50 -0400 Received: from smtpi4.ngi.it ([88.149.128.104]:55088 "EHLO smtpi4.ngi.it" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752102Ab2CVQJr (ORCPT ); Thu, 22 Mar 2012 12:09:47 -0400 X-Greylist: delayed 376 seconds by postgrey-1.27 at vger.kernel.org; Thu, 22 Mar 2012 12:09:47 EDT Message-ID: <4F6B4D4A.2040103@denx.de> Date: Thu, 22 Mar 2012 17:03:22 +0100 From: Stefano Babic User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.2) Gecko/20120216 Thunderbird/10.0.2 MIME-Version: 1.0 To: Kyle Manna CC: Tony Lindgren , linux-omap@vger.kernel.org, Paul Walmsley , Kevin Hilman , Nicolas Pitre , Benoit Cousson , linux-kernel@vger.kernel.org, Peter Ujfalusi , Santosh Shilimkar , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] ARM: OMAP: Add support for AM35xx UART4/ttyO3 References: <1318963661-27755-1-git-send-email-kyle.manna@fuel7.com> In-Reply-To: <1318963661-27755-1-git-send-email-kyle.manna@fuel7.com> X-Enigmail-Version: 1.3.5 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 18/10/2011 20:47, Kyle Manna wrote: > Add hwmod support to enable access to UART4 of the AM35xx series of > chips. The UART4 device referenced from the TRM will show up as ttyO3. > > This was tested on an AM3505. > > Signed-off-by: Kyle Manna > --- Hi Kyle, > arch/arm/mach-omap2/clock3xxx_data.c | 11 ++++++ > arch/arm/mach-omap2/omap_hwmod_3xxx_data.c | 52 ++++++++++++++++++++++++++++ > arch/arm/mach-omap2/prcm-common.h | 2 + > arch/arm/plat-omap/include/plat/irqs.h | 2 +- > arch/arm/plat-omap/include/plat/serial.h | 1 + > 5 files changed, 67 insertions(+), 1 deletions(-) Can I gently ask you which pinmux setup do you use to test your patch ? I am trying to make uart4 working on a am3517 with mainline kernel (3.3+, your patch is merged). However, on my board the uart4 pins are shared with the camera, and not with SD, as maybe is more common. I set the pinmux to switch the pins (gpio_95 / gpio_96 / gpio_97 /gpio_98) to the uart4, and ttyO3 is registered and available, and thanks your patch both clocks iclk and fclk are active. However, I cannot see activity on the tx line if I try to send some characters. Maybe do you use the same pinmux and am I forgetting something else ? Thanks, Stefano Babic -- ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic@denx.de =====================================================================