* [PATCH] x86, build: remove unused include
@ 2012-02-15 16:49 Andreas Bießmann
2012-03-22 10:17 ` Andreas Bießmann
0 siblings, 1 reply; 4+ messages in thread
From: Andreas Bießmann @ 2012-02-15 16:49 UTC (permalink / raw)
To: linux-kernel
Cc: H. Peter Anvin, Thomas Gleixner, x86, Michal Marek, Matt Fleming,
Ingo Molnar, Andreas Bießmann
Commit 079f85e624189292d1c818b47764916bf8cf84a8 removed necessity for
sys/sysmacros.h include but missed to remove the include.
Still requiring sys/sysmacros.h for build tool breaks cross compiling x86 kernel
on non linux style systems which may not offer sys/sysmacros.h.
Signed-off-by: Andreas Bießmann <andreas@biessmann.de>
---
arch/x86/boot/tools/build.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/arch/x86/boot/tools/build.c b/arch/x86/boot/tools/build.c
index 4e9bd6b..52628cd 100644
--- a/arch/x86/boot/tools/build.c
+++ b/arch/x86/boot/tools/build.c
@@ -29,7 +29,6 @@
#include <stdarg.h>
#include <sys/types.h>
#include <sys/stat.h>
-#include <sys/sysmacros.h>
#include <unistd.h>
#include <fcntl.h>
#include <sys/mman.h>
--
1.7.9
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] x86, build: remove unused include
2012-02-15 16:49 [PATCH] x86, build: remove unused include Andreas Bießmann
@ 2012-03-22 10:17 ` Andreas Bießmann
2012-03-22 18:30 ` H. Peter Anvin
0 siblings, 1 reply; 4+ messages in thread
From: Andreas Bießmann @ 2012-03-22 10:17 UTC (permalink / raw)
To: linux-kernel
Cc: H. Peter Anvin, Thomas Gleixner, x86, Michal Marek, Matt Fleming,
Ingo Molnar
On Wed, Feb 15, 2012 at 05:49:49PM +0100, Andreas Bießmann wrote:
> Commit 079f85e624189292d1c818b47764916bf8cf84a8 removed necessity for
> sys/sysmacros.h include but missed to remove the include.
>
> Still requiring sys/sysmacros.h for build tool breaks cross compiling x86 kernel
> on non linux style systems which may not offer sys/sysmacros.h.
>
> Signed-off-by: Andreas Bießmann <andreas@biessmann.de>
> ---
> arch/x86/boot/tools/build.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/arch/x86/boot/tools/build.c b/arch/x86/boot/tools/build.c
> index 4e9bd6b..52628cd 100644
> --- a/arch/x86/boot/tools/build.c
> +++ b/arch/x86/boot/tools/build.c
> @@ -29,7 +29,6 @@
> #include <stdarg.h>
> #include <sys/types.h>
> #include <sys/stat.h>
> -#include <sys/sysmacros.h>
> #include <unistd.h>
> #include <fcntl.h>
> #include <sys/mman.h>
> --
are there any objections against that patch? could anyone take it if not?
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] x86, build: remove unused include
2012-03-22 10:17 ` Andreas Bießmann
@ 2012-03-22 18:30 ` H. Peter Anvin
2012-03-22 19:44 ` Andreas Bießmann
0 siblings, 1 reply; 4+ messages in thread
From: H. Peter Anvin @ 2012-03-22 18:30 UTC (permalink / raw)
To: Andreas Bießmann
Cc: linux-kernel, Thomas Gleixner, x86, Michal Marek, Matt Fleming,
Ingo Molnar
On 03/22/2012 03:17 AM, Andreas Bießmann wrote:
> On Wed, Feb 15, 2012 at 05:49:49PM +0100, Andreas Bießmann wrote:
>> Commit 079f85e624189292d1c818b47764916bf8cf84a8 removed necessity for
>> sys/sysmacros.h include but missed to remove the include.
>>
>> Still requiring sys/sysmacros.h for build tool breaks cross compiling x86 kernel
>> on non linux style systems which may not offer sys/sysmacros.h.
>>
>> Signed-off-by: Andreas Bießmann <andreas@biessmann.de>
>> ---
>> arch/x86/boot/tools/build.c | 1 -
>> 1 files changed, 0 insertions(+), 1 deletions(-)
>>
>> diff --git a/arch/x86/boot/tools/build.c b/arch/x86/boot/tools/build.c
>> index 4e9bd6b..52628cd 100644
>> --- a/arch/x86/boot/tools/build.c
>> +++ b/arch/x86/boot/tools/build.c
>> @@ -29,7 +29,6 @@
>> #include <stdarg.h>
>> #include <sys/types.h>
>> #include <sys/stat.h>
>> -#include <sys/sysmacros.h>
>> #include <unistd.h>
>> #include <fcntl.h>
>> #include <sys/mman.h>
>> --
>
> are there any objections against that patch? could anyone take it if not?
An equivalent patch has been in tip:x86/build for a while and was just
pulled upstream by Linus.
--
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel. I don't speak on their behalf.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] x86, build: remove unused include
2012-03-22 18:30 ` H. Peter Anvin
@ 2012-03-22 19:44 ` Andreas Bießmann
0 siblings, 0 replies; 4+ messages in thread
From: Andreas Bießmann @ 2012-03-22 19:44 UTC (permalink / raw)
To: H. Peter Anvin
Cc: linux-kernel, Thomas Gleixner, x86, Michal Marek, Matt Fleming,
Ingo Molnar
On 22.03.12 19:30, H. Peter Anvin wrote:
> On 03/22/2012 03:17 AM, Andreas Bießmann wrote:
>> On Wed, Feb 15, 2012 at 05:49:49PM +0100, Andreas Bießmann wrote:
>>> Commit 079f85e624189292d1c818b47764916bf8cf84a8 removed necessity for
>>> sys/sysmacros.h include but missed to remove the include.
> An equivalent patch has been in tip:x86/build for a while and was just
> pulled upstream by Linus.
sorry for the noise, I did only search for my patch in history and did
not check the file.
regards
Andreas Bießmann
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-03-22 19:45 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-02-15 16:49 [PATCH] x86, build: remove unused include Andreas Bießmann
2012-03-22 10:17 ` Andreas Bießmann
2012-03-22 18:30 ` H. Peter Anvin
2012-03-22 19:44 ` Andreas Bießmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox