Re: [PATCH v6 6/7] mm/memcg: kill mem_cgroup_lru_del()

Konstantin Khlebnikov
2012-03-26T16:05:39Z

Michal Hocko wrote:
> On Fri 23-03-12 01:56:39, Konstantin Khlebnikov wrote:
>> This patch kills mem_cgroup_lru_del(), we can use mem_cgroup_lru_del_list()
>> instead. On 0-order isolation we already have right lru list id.
>>
>> Signed-off-by: Konstantin Khlebnikov<khlebnikov@openvz.org>
>> Cc: KAMEZAWA Hiroyuki<kamezawa.hiroyu@jp.fujitsu.com>
>> Cc: Hugh Dickins<hughd@google.com>
>
> Yes, looks good
> Acked-by: Michal Hocko<mhocko@suse.cz>
>
> Just a small nit..
> [...]
>> diff --git a/mm/vmscan.c b/mm/vmscan.c
>> index 5f6ed98..9de66be 100644
>> --- a/mm/vmscan.c
>> +++ b/mm/vmscan.c
> [...]
>> @@ -1205,8 +1205,11 @@ static unsigned long isolate_lru_pages(unsigned long nr_to_scan,
>>
>> if (__isolate_lru_page(cursor_page, mode) == 0) {
>> unsigned int isolated_pages;
>> + enum lru_list cursor_lru;
>>
>> - mem_cgroup_lru_del(cursor_page);
>> + cursor_lru = page_lru(cursor_page);
>> + mem_cgroup_lru_del_list(cursor_page,
>> + cursor_lru);
>
> Why not mem_cgroup_lru_del_list(cursor_page,
> page_lru(cursor_page));
> The patch would be smaller and it doesn't make checkpatch unhappy as well.

Lumpy-reclaim supposed to be removed soon, so...

>
>> list_move(&cursor_page->lru, dst);
>> isolated_pages = hpage_nr_pages(cursor_page);
>> nr_taken += isolated_pages;
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>> Please read the FAQ at http://www.tux.org/lkml/
>