From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756620Ab2CWWHG (ORCPT ); Fri, 23 Mar 2012 18:07:06 -0400 Received: from oproxy3-pub.bluehost.com ([69.89.21.8]:52934 "HELO oproxy3-pub.bluehost.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1754574Ab2CWWHF (ORCPT ); Fri, 23 Mar 2012 18:07:05 -0400 Message-ID: <4F6CF403.9030409@xenotime.net> Date: Fri, 23 Mar 2012 15:06:59 -0700 From: Randy Dunlap User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.15) Gecko/20110323 Thunderbird/3.1.9 MIME-Version: 1.0 To: David Teigland CC: Steven Whitehouse , linux-kernel@vger.kernel.org, cluster-devel@redhat.com, bpoirier@suse.de Subject: Re: GFS2: Pre-pull patch posting (merge window) References: <1332152728-4027-1-git-send-email-swhiteho@redhat.com> <4F674696.7030602@xenotime.net> <1332169153.2689.20.camel@menhir> <4F674E4F.5080904@xenotime.net> <1332171247.2689.28.camel@menhir> <20120323194152.GD24746@redhat.com> <4F6CD7AD.9030306@xenotime.net> <20120323201820.GE24746@redhat.com> In-Reply-To: <20120323201820.GE24746@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Identified-User: {1807:box742.bluehost.com:xenotime:xenotime.net} {sentby:smtp auth 50.53.38.135 authed with rdunlap@xenotime.net} Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/23/2012 01:18 PM, David Teigland wrote: > On Fri, Mar 23, 2012 at 01:06:05PM -0700, Randy Dunlap wrote: >>>> GFS2_FS selects DLM (if GFS2_FS_LOCKING_DLM, which is enabled). >>>> GFS2_FS selects IP_SCTP if DLM_SCTP, which is not enabled and not >>>> used anywhere else in the kernel tree AFAICT. >>>> DLM just always selects IP_SCTP. >>> >>> Here's what we have now: >>> >>> config GFS2_FS >>> tristate "GFS2 file system support" >>> depends on (64BIT || LBDAF) >>> select DLM if GFS2_FS_LOCKING_DLM >>> select CONFIGFS_FS if GFS2_FS_LOCKING_DLM >>> select SYSFS if GFS2_FS_LOCKING_DLM >>> select IP_SCTP if DLM_SCTP >>> select FS_POSIX_ACL >>> select CRC32 >>> select QUOTACTL >>> >>> menuconfig DLM >>> tristate "Distributed Lock Manager (DLM)" >>> depends on EXPERIMENTAL && INET >>> depends on SYSFS && CONFIGFS_FS && (IPV6 || IPV6=n) >>> select IP_SCTP >>> >>> Why does gfs2 Kconfig bother with SCTP at all? It seems that line should >>> just be removed. I'll also remove EXPERIMENTAL. I don't understand the >>> vagaries of Kconfig, so a dumb question, how could sctp_do_peeloff >>> possibly be undefined if we're selecting SCTP. >> >> What is selecting SCTP? DLM? so GFS2 selects DLM, but selects >> don't follow dependency chains. Also, the "select IP_SCTP if DLM_SCTP" >> in GFS2 is meaningless since there is no DLM_SCTP. > > https://lkml.org/lkml/2012/3/8/222 seems to have caused this by adding > the new dependency on the sctp module without any Kconfig changes. bad URL? I don't see how that patch affects this area at all. > Should that patch have added depends IP_SCTP to the dlm and gfs2? Sounds reasonable (but I haven't seen the patch). -- ~Randy