From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754906Ab2CZINA (ORCPT ); Mon, 26 Mar 2012 04:13:00 -0400 Received: from mail-bk0-f46.google.com ([209.85.214.46]:58204 "EHLO mail-bk0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754337Ab2CZIM6 (ORCPT ); Mon, 26 Mar 2012 04:12:58 -0400 Message-ID: <4F702503.3060009@suse.cz> Date: Mon, 26 Mar 2012 10:12:51 +0200 From: Jiri Slaby User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:12.0) Gecko/20120314 Thunderbird/12.0 MIME-Version: 1.0 To: Tilman Schmidt CC: Greg KH , linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, netdev@vger.kernel.org, hjlipp@web.de Subject: Re: [GIT PATCH] TTY/serial patches for 3.4-rc1 References: <20120319195649.GD9883@kroah.com> <20120325171837.67310140074@xenon.ts.pxnet.com> In-Reply-To: <20120325171837.67310140074@xenon.ts.pxnet.com> X-Enigmail-Version: 1.4 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/25/2012 07:12 PM, Tilman Schmidt wrote: > Jiri, Greg, > > On 19.03.2012 20:56, Greg KH wrote: >> tty and serial merge for 3.4-rc1 > [...] >> Jiri Slaby (77): > [...] >> TTY: isdn/gigaset, do not set tty->driver_data to NULL > > It seems that the amendment we discussed on 05.03.2012 did not > make it into this patch. It would be nice if the following patch > could still be added on top of it. Ah, yes, I forgot, of course. Thanks for posting it. > From: Tilman Schmidt > Date: Sun, 25 Mar 2012 12:21:57 +0200 > Subject: [PATCH] isdn/gigaset: use gig_dbg() for debugging output > > The "TTY buffer in tty_port" patchset introduced an opencoded > debug message in the Gigaset tty device if_close() function. > Change it to use the gig_dbg() macro like everywhere else in > the driver. > > Signed-off-by: Tilman Schmidt > --- > drivers/isdn/gigaset/interface.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/isdn/gigaset/interface.c b/drivers/isdn/gigaset/interface.c > index b3d6ac1..a6d9fd2 100644 > --- a/drivers/isdn/gigaset/interface.c > +++ b/drivers/isdn/gigaset/interface.c > @@ -176,7 +176,7 @@ static void if_close(struct tty_struct *tty, struct file *filp) > struct cardstate *cs = tty->driver_data; > > if (!cs) { /* happens if we didn't find cs in open */ > - printk(KERN_DEBUG "%s: no cardstate\n", __func__); > + gig_dbg(DEBUG_IF, "%s: no cardstate", __func__); > return; > } > -- js suse labs