From: "H. Peter Anvin" <hpa@zytor.com>
To: Suresh Siddha <suresh.b.siddha@intel.com>
Cc: Ingo Molnar <mingo@kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Len Brown <lenb@kernel.org>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [patch] x86, tlb: switch cr3 in leave_mm() only when needed
Date: Mon, 26 Mar 2012 15:47:51 -0700 [thread overview]
Message-ID: <4F70F217.4060005@zytor.com> (raw)
In-Reply-To: <1332802025.12381.2.camel@sbsiddha-desk.sc.intel.com>
On 03/26/2012 03:47 PM, Suresh Siddha wrote:
> On Fri, 2012-03-23 at 09:37 +0100, Ingo Molnar wrote:
>> * Suresh Siddha <suresh.b.siddha@intel.com> wrote:
>>
>>> I was reviewing this code in some other context and thought
>>> this optimization makes sense. Unless someone beats me, I can
>>> collect some data on Monday.
>>
>> Would be really nice to get this data.
>>
>
> On an idle system with 32logical cpu's (2 socket/8-core each) the
> original kernel did the unnecessary load_cr3 2988 times during an
> interval of 5 seconds.
>
> With the fix, that count drops to 9 times.
>
Nice.
-hpa
next prev parent reply other threads:[~2012-03-26 22:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-22 23:33 [patch] x86, tlb: switch cr3 in leave_mm() only when needed Suresh Siddha
2012-03-22 23:44 ` Linus Torvalds
2012-03-23 0:01 ` Suresh Siddha
2012-03-23 0:20 ` H. Peter Anvin
2012-03-23 0:37 ` Linus Torvalds
2012-03-23 0:51 ` Suresh Siddha
2012-03-23 8:37 ` Ingo Molnar
2012-03-26 22:47 ` Suresh Siddha
2012-03-26 22:47 ` H. Peter Anvin [this message]
2012-03-23 0:31 ` [tip:x86/mm] x86, tlb: Switch " tip-bot for Suresh Siddha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F70F217.4060005@zytor.com \
--to=hpa@zytor.com \
--cc=lenb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=suresh.b.siddha@intel.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox