From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755125Ab2C0RRz (ORCPT ); Tue, 27 Mar 2012 13:17:55 -0400 Received: from terminus.zytor.com ([198.137.202.10]:40708 "EHLO mail.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754808Ab2C0RRx (ORCPT ); Tue, 27 Mar 2012 13:17:53 -0400 Message-ID: <4F71F634.1050503@zytor.com> Date: Tue, 27 Mar 2012 10:17:40 -0700 From: "H. Peter Anvin" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.1) Gecko/20120209 Thunderbird/10.0.1 MIME-Version: 1.0 To: Michal Nazarewicz CC: Andrew Morton , Denys Vlasenko , linux-kernel@vger.kernel.org, Douglas W Jones , Michal Nazarewicz Subject: Re: [PATCH 1/1] vsprintf: optimize decimal conversion (again) References: <201203262047.17865.vda.linux@googlemail.com> <201203262051.24271.vda.linux@googlemail.com> <20120326125129.78975baf.akpm@linux-foundation.org> <20120326131304.018a5f4b.akpm@linux-foundation.org> <4F70CFA4.5020503@zytor.com> In-Reply-To: X-Enigmail-Version: 1.4 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/27/2012 10:12 AM, Michal Nazarewicz wrote: > > Maybe a regular “if” instead of macro would suffice here? Compiler should > be smart enough to optimise out the dead path. > Yes, a regular if would work, but it's also pointless. -hpa