From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932370Ab2C1LXh (ORCPT ); Wed, 28 Mar 2012 07:23:37 -0400 Received: from mail-bk0-f46.google.com ([209.85.214.46]:42650 "EHLO mail-bk0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758258Ab2C1LXf (ORCPT ); Wed, 28 Mar 2012 07:23:35 -0400 Message-ID: <4F72F45D.7090800@mvista.com> Date: Wed, 28 Mar 2012 15:22:05 +0400 From: Sergei Shtylyov User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:11.0) Gecko/20120312 Thunderbird/11.0 MIME-Version: 1.0 To: Lin Ming CC: Zhang Rui , Jeff Garzik , Alan Stern , "Rafael J. Wysocki" , Tejun Heo , Aaron Lu , linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org, linux-scsi@vger.kernel.org, linux-pm@vger.kernel.org, linux-acpi Subject: Re: [PATCH v3 4/7] libata: detech Device Attention support References: <1332915722-15963-1-git-send-email-ming.m.lin@intel.com> <1332915722-15963-5-git-send-email-ming.m.lin@intel.com> In-Reply-To: <1332915722-15963-5-git-send-email-ming.m.lin@intel.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello. On 28-03-2012 10:21, Lin Ming wrote: > Add a new flag ATA_DFLAG_DA to indicate that device supports "Device > Attention". > Acked-by: Aaron Lu > Signed-off-by: Lin Ming [...] > diff --git a/include/linux/ata.h b/include/linux/ata.h > index 32df2b6..6ee41cc 100644 > --- a/include/linux/ata.h > +++ b/include/linux/ata.h > @@ -578,6 +578,7 @@ static inline int ata_is_data(u8 prot) > ((u64) (id)[(n) + 0]) ) > > #define ata_id_cdb_intr(id) (((id)[ATA_ID_CONFIG]& 0x60) == 0x20) > +#define atapi_id_has_da(id) ((id)[77]& (1<< 4)) We prefix these macros with 'ata_' despite them being applied to IDENTIFY DEVICE data or IDENTIFY PAKCET DEVICE data. ata_id_cdb_intr(), for example, applies only to IDENTIFY PAKCET DEVICE data. MBR, Sergei