From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752740Ab2C2Fga (ORCPT ); Thu, 29 Mar 2012 01:36:30 -0400 Received: from cn.fujitsu.com ([222.73.24.84]:23996 "EHLO song.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1750974Ab2C2FgX (ORCPT ); Thu, 29 Mar 2012 01:36:23 -0400 X-IronPort-AV: E=Sophos;i="4.75,335,1330876800"; d="scan'208";a="4646239" Message-ID: <4F73F4E6.4060104@cn.fujitsu.com> Date: Thu, 29 Mar 2012 13:36:38 +0800 From: Ren Mingxin User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.9) Gecko/20110412 CentOS/3.1.3-1.el6.centos Thunderbird/3.1.3 MIME-Version: 1.0 To: "Michael S. Tsirkin" , jens.axboe@oracle.com CC: Rusty Russell , LKML , Tejun Heo , kvm@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-scsi@vger.kernel.org Subject: Re: [PATCH] virtio_blk: add helper function to support mass of disks naming References: <4F72B5B3.6020602@cn.fujitsu.com> <20120328105819.GD6194@redhat.com> In-Reply-To: <20120328105819.GD6194@redhat.com> X-MIMETrack: Itemize by SMTP Server on mailserver/fnst(Release 8.5.1FP4|July 25, 2010) at 2012-03-29 13:34:04, Serialize by Router on mailserver/fnst(Release 8.5.1FP4|July 25, 2010) at 2012-03-29 13:34:06, Serialize complete at 2012-03-29 13:34:06 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=ISO-8859-1; format=flowed Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/28/2012 06:58 PM, Michael S. Tsirkin wrote: > On Wed, Mar 28, 2012 at 02:54:43PM +0800, Ren Mingxin wrote: >> Hi, >> >> The current virtblk's naming algorithm just supports 26^3 >> disks. If there are mass of virtblks(exceeding 26^3), there >> will be disks with the same name. >> >> According to "sd_format_disk_name()", I add function >> "virtblk_name_format()" for virtblk to support mass of >> disks. >> >> Signed-off-by: Ren Mingxin > Nod. This is basically what 3e1a7ff8a0a7b948f2684930166954f9e8e776fe > did. Except, maybe we should move this function into block core > instead of duplicating it? Where would be a good place to put it? Yes, this was also what I thought. How about placing the "sd_format_disk_name()" as "disk_name_format()" into "block/genhd.c" ("include/linux/genhd.h")? Thanks. Ren