Re: [PATCH] staging/vme: Fix module parameters in next-20120323

[Martyn Welch <martyn.welch@ge.com>]

On 23/03/12 10:21, Gerard Snitselaar wrote:
> loopback should be declared bool, and variant probably shouldn't be
> const.
> 
> Signed-off-by: Gerard Snitselaar <dev@snitselaar.org>

Looks good, thanks,

Acked-by: Martyn Welch <martyn.welch@ge.com>

> ---
>  drivers/staging/vme/devices/vme_pio2_core.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/vme/devices/vme_pio2_core.c b/drivers/staging/vme/devices/vme_pio2_core.c
> index 9fedc44..573c800 100644
> --- a/drivers/staging/vme/devices/vme_pio2_core.c
> +++ b/drivers/staging/vme/devices/vme_pio2_core.c
> @@ -35,10 +35,10 @@ static int vector[PIO2_CARDS_MAX];
>  static int vector_num;
>  static int level[PIO2_CARDS_MAX];
>  static int level_num;
> -static const char *variant[PIO2_CARDS_MAX];
> +static char *variant[PIO2_CARDS_MAX];
>  static int variant_num;
>  
> -static int loopback;
> +static bool loopback;
>  
>  static int pio2_match(struct vme_dev *);
>  static int __devinit pio2_probe(struct vme_dev *);


-- 
Martyn Welch (Lead Software Engineer)  | Registered in England and Wales
GE Intelligent Platforms               | (3828642) at 100 Barbirolli Square
T +44(0)1327322748                     | Manchester, M2 3AB
E martyn.welch@ge.com                  | VAT:GB 927559189