From: Sergei Shtylyov <sshtylyov@mvista.com>
To: Tomoki Sekiyama <tomoki.sekiyama@gmail.com>
Cc: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] USB: yurex: remove allocation of coherent buffer for setup-packet buffer
Date: Thu, 29 Mar 2012 15:57:23 +0400 [thread overview]
Message-ID: <4F744E23.3040207@mvista.com> (raw)
In-Reply-To: <4F739CBB.8060602@gmail.com>
Hello.
On 29-03-2012 3:20, Tomoki Sekiyama wrote:
> Removes allocation of coherent buffer for the control-request setup-packet
> buffer from the yurex driver. Using coherent buffers for setup-packet is
> obsoleted and does not work with some USB host implementations.
> This patch also fixes missing URB_NO_TRANSFER_DMA_MAP flag in urb.
Looks like the patch should be split into two then as it does two different
things.
> Signed-off-by: Tomoki Sekiyama<tomoki.sekiyama@gmail.com>
> ---
> drivers/usb/misc/yurex.c | 10 +++-------
> 1 files changed, 3 insertions(+), 7 deletions(-)
> diff --git a/drivers/usb/misc/yurex.c b/drivers/usb/misc/yurex.c
> index 897edda..7020146 100644
> --- a/drivers/usb/misc/yurex.c
> +++ b/drivers/usb/misc/yurex.c
> @@ -99,9 +99,7 @@ static void yurex_delete(struct kref *kref)
> usb_put_dev(dev->udev);
> if (dev->cntl_urb) {
> usb_kill_urb(dev->cntl_urb);
> - if (dev->cntl_req)
> - usb_free_coherent(dev->udev, YUREX_BUF_SIZE,
> - dev->cntl_req, dev->cntl_urb->setup_dma);
> + kfree(dev->cntl_req);
> if (dev->cntl_buffer)
> usb_free_coherent(dev->udev, YUREX_BUF_SIZE,
> dev->cntl_buffer, dev->cntl_urb->transfer_dma);
> @@ -234,9 +232,7 @@ static int yurex_probe(struct usb_interface *interface, const struct usb_device_
> }
>
> /* allocate buffer for control req */
> - dev->cntl_req = usb_alloc_coherent(dev->udev, YUREX_BUF_SIZE,
> - GFP_KERNEL,
> - &dev->cntl_urb->setup_dma);
> + dev->cntl_req = kmalloc(YUREX_BUF_SIZE, GFP_KERNEL);
> if (!dev->cntl_req) {
> err("Could not allocate cntl_req");
> goto error;
> @@ -286,7 +282,7 @@ static int yurex_probe(struct usb_interface *interface, const struct usb_device_
> usb_rcvintpipe(dev->udev, dev->int_in_endpointAddr),
> dev->int_buffer, YUREX_BUF_SIZE, yurex_interrupt,
> dev, 1);
> - dev->cntl_urb->transfer_flags |= URB_NO_TRANSFER_DMA_MAP;
> + dev->urb->transfer_flags |= URB_NO_TRANSFER_DMA_MAP;
> if (usb_submit_urb(dev->urb, GFP_KERNEL)) {
> retval = -EIO;
> err("Could not submitting URB");
WBR, Sergei
next prev parent reply other threads:[~2012-03-29 11:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-28 23:20 [PATCH] USB: yurex: remove allocation of coherent buffer for setup-packet buffer Tomoki Sekiyama
2012-03-29 11:57 ` Sergei Shtylyov [this message]
2012-03-29 12:51 ` Tomoki Sekiyama
2012-03-29 23:51 ` [PATCH 1/2] USB: yurex: Remove " Tomoki Sekiyama
2012-03-29 23:51 ` [PATCH 2/2] USB: yurex: Fix missing URB_NO_TRANSFER_DMA_MAP flag in urb Tomoki Sekiyama
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F744E23.3040207@mvista.com \
--to=sshtylyov@mvista.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=tomoki.sekiyama@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox