Re: [PATCH 2/6] trace: add support for 32 bit compat syscalls on x86_64

Vaibhav Nagarnaik
2012-03-28T21:10:56Z

On Mon, Mar 26, 2012 at 9:49 PM, H. Peter Anvin <hpa@zytor.com> wrote:
> On 03/26/2012 11:39 AM, Vaibhav Nagarnaik wrote:
>> +/*
>> + * syscall metadata for 32 bit compatible system calls
>> + *
>> + * The metadata entries are in the same order as the system call table
>> + * but this is just to make it easier to check them for completeness
>> + * and correctness.
>> + */
>> +
>> +COMPAT_SYSCALL_METADATA0(restart_syscall)
>> +COMPAT_SYSCALL_METADATA1(exit, int, error_code)
>   [...]
>> +COMPAT_SYSCALL_METADATA5(recvmmsg, int, fd, struct mmsghdr __user *, mmsg, unsigned int, vlen, unsigned int, flags, struct timespec __user *, timeout)
>
>> +/*
>> + * This is truly horrible.
>
> Yes, it is.  How on Earth do you expect the above to ever be maintained?

You are right. I found that I can just reuse the SYSCALL_DEFINEx macro
to define the compat syscall metadata. I am sending the new patch, can
you take a look again?

Thanks

Vaibhav Nagarnaik