public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "H. Peter Anvin" <hpa@zytor.com>
To: Maarten ter Huurne <maarten@treewalker.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] /dev/mem: Add kernel config option to omit this device.
Date: Thu, 29 Mar 2012 13:07:39 -0700	[thread overview]
Message-ID: <4F74C10B.3040503@zytor.com> (raw)
In-Reply-To: <1679935.Pf8rWZIDTT@hyperion>

On 03/29/2012 12:32 PM, Maarten ter Huurne wrote:
> On Thursday 29 March 2012 10:30:14 H. Peter Anvin wrote:
>> On 03/29/2012 10:22 AM, Maarten ter Huurne wrote:
>>> Many systems don't need /dev/mem, so make it optional.
>>> It saves some space on embedded systems.
>>>
>>> Signed-off-by: Maarten ter Huurne <maarten@treewalker.org>
>>
>> I would like to see it being modular if it is made optional.  I think
>> that would be the right thing anyway.
> 
> By modular, do you mean splitting off the code from drivers/char/mem.c into 
> a new source file?
> 
> In mem.c there are several static functions used by more than one device, 
> but I think /dev/mem, /dev/kmem and /dev/port are relatively independent of 
> the other devices, so splitting off those three would be an option.
> 

Yes, splitting them and making it possible to compile them as modules.

And certainly the devices you list above are really quite different
from, say /dev/null or /dev/zero.

	-hpa


      reply	other threads:[~2012-03-29 20:08 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-29 17:22 [PATCH] /dev/mem: Add kernel config option to omit this device Maarten ter Huurne
2012-03-29 17:30 ` H. Peter Anvin
2012-03-29 19:32   ` Maarten ter Huurne
2012-03-29 20:07     ` H. Peter Anvin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F74C10B.3040503@zytor.com \
    --to=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maarten@treewalker.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox