From: David Daney <ddaney.cavm@gmail.com>
To: Namhyung Kim <namhyung@gmail.com>, Ingo Molnar <mingo@kernel.org>
Cc: Arnaldo Carvalho de Melo <acme@infradead.org>,
linux-kernel@vger.kernel.org, Ingo Molnar <mingo@elte.hu>,
Jiri Olsa <jolsa@redhat.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Arnaldo Carvalho de Melo <acme@redhat.com>
Subject: Re: [PATCH 9/9] perf tools: Remove auto-generated bison/flex files
Date: Fri, 30 Mar 2012 10:09:14 -0700 [thread overview]
Message-ID: <4F75E8BA.4090907@gmail.com> (raw)
In-Reply-To: <87iphmm44e.fsf@gmail.com>
On 03/30/2012 09:43 AM, Namhyung Kim wrote:
> Hi,
>
> Arnaldo Carvalho de Melo<acme@infradead.org> wrote:
>> From: Ingo Molnar<mingo@kernel.org>
>>
>> These should not be in the Git history - they are auto-generated.
>>
>> Extend the Makefile rules of the parser files to include the generation
>> run.
>>
>> Signed-off-by: Ingo Molnar<mingo@elte.hu>
[...]
>>
>> +FLEX = $(CROSS_COMPILE)flex
>> +BISON= $(CROSS_COMPILE)bison
>
> Just out of curiousity, is this $(CROSS_COMPILE) prefix really needed
> for flex/bison?
>
I think not. Actually, I think it is actively incorrect.
I have done quite a bit of cross building of things requiring either
bison or flex, and have never encountered $(CROSS_COMPILE)bison, so I
would think that it is unlikely that many people have one. On the other
hand the native tools work fine.
David Daney
next prev parent reply other threads:[~2012-03-30 17:09 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-30 16:09 [GIT PULL 0/9] perf/urgent fixes Arnaldo Carvalho de Melo
2012-03-30 16:09 ` [PATCH 1/9] perf tools: Fix display of first level of callchains Arnaldo Carvalho de Melo
2012-03-30 16:09 ` [PATCH 2/9] perf tools: Fix bug in raw sample parsing Arnaldo Carvalho de Melo
2012-03-30 16:09 ` [PATCH 3/9] perf symbols: Do not include libgen.h Arnaldo Carvalho de Melo
2012-03-30 16:09 ` [PATCH 4/9] perf symbols: Handle NULL dso in dso__name_len Arnaldo Carvalho de Melo
2012-03-30 16:09 ` [PATCH 5/9] perf probe: Finder fails to resolve function name to address Arnaldo Carvalho de Melo
2012-03-30 16:09 ` [PATCH 6/9] perf annotate: addr2line wants addresses in same format as objdump Arnaldo Carvalho de Melo
2012-03-30 16:09 ` [PATCH 7/9] perf tools: Add missing ref-cycles event back to event parser Arnaldo Carvalho de Melo
2012-03-30 16:09 ` [PATCH 8/9] perf annotate: Fix off by one symbol hist size allocation and hit accounting Arnaldo Carvalho de Melo
2012-03-30 16:09 ` [PATCH 9/9] perf tools: Remove auto-generated bison/flex files Arnaldo Carvalho de Melo
2012-03-30 16:43 ` Namhyung Kim
2012-03-30 17:09 ` David Daney [this message]
2012-03-30 22:01 ` Arnaldo Carvalho de Melo
2012-03-31 7:31 ` [GIT PULL 0/9] perf/urgent fixes Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F75E8BA.4090907@gmail.com \
--to=ddaney.cavm@gmail.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@infradead.org \
--cc=acme@redhat.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mingo@kernel.org \
--cc=namhyung@gmail.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox