From: Randy Dunlap <rdunlap@xenotime.net>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Lucas De Marchi <lucas.demarchi@profusion.mobi>
Subject: [PATCH 7/8] Documentation: replace install commands with softdeps
Date: Fri, 30 Mar 2012 13:37:20 -0700 [thread overview]
Message-ID: <4F761980.4050307@xenotime.net> (raw)
In-Reply-To: <4F761580.3020807@xenotime.net>
From: Lucas De Marchi <lucas.demarchi@profusion.mobi>
Documentation: replace install commands with softdeps
Install commands should not be used to specify soft dependencies among
modules. When loading modules it's much better to have a softdep that
modprobe knows what's being done than having to fork/exec another
instance of modprobe to load the other module.
By using a softdep user has also an option to remove the dependencies
when removing the module (and if its refcount dropped to 0)
Signed-off-by: Lucas De Marchi <lucas.demarchi@profusion.mobi>
---
v2: addressed comments from Takashi Iwai and split the patch in two. There were
some changes to install commands that are better placed in a separate patch
Documentation/networking/bonding.txt | 3 +--
Documentation/sound/oss/AudioExcelDSP16 | 4 ++--
Documentation/sound/oss/README.modules | 2 +-
3 files changed, 4 insertions(+), 5 deletions(-)
--- lnx-33.orig/Documentation/networking/bonding.txt
+++ lnx-33/Documentation/networking/bonding.txt
@@ -1822,8 +1822,7 @@ modules.conf manual page.
In this case, the following can be added to config files in
/etc/modprobe.d/ as:
-install bonding /sbin/modprobe tg3; /sbin/modprobe e1000;
- /sbin/modprobe --ignore-install bonding
+softdep bonding pre: tg3 e1000
This will load tg3 and e1000 modules before loading the bonding one.
Full documentation on this can be found in the modprobe.d and modprobe
--- lnx-33.orig/Documentation/sound/oss/AudioExcelDSP16
+++ lnx-33/Documentation/sound/oss/AudioExcelDSP16
@@ -54,8 +54,8 @@ Loading MSS and OPL3 needs to pre load t
the sound card. Installation dependencies must be written in configuration
files under /etc/modprobe.d/ directory:
-install ad1848 /sbin/modprobe aedsp16 && /sbin/modprobe -i ad1848
-install opl3 /sbin/modprobe aedsp16 && /sbin/modprobe -i opl3
+softdep ad1848 pre: aedsp16
+softdep opl3 pre: aedsp16
Then you must load the sound modules stack in this order:
sound -> aedsp16 -> [ ad1848, opl3 ]
--- lnx-33.orig/Documentation/sound/oss/README.modules
+++ lnx-33/Documentation/sound/oss/README.modules
@@ -36,7 +36,7 @@ options adlib_card io=0x388 # FM syn
Alternatively, if you have compiled in kernel level ISAPnP support:
alias char-major-14 sb
-post-install sb /sbin/modprobe "-k" "adlib_card"
+softdep sb post: adlib_card
options adlib_card io=0x388
The effect of this is that the sound driver and all necessary bits and
next prev parent reply other threads:[~2012-03-30 20:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <4F761580.3020807@xenotime.net>
2012-03-30 20:37 ` [PATCH 2/8] Documentation: mention scripts/diffconfig tool Randy Dunlap
2012-03-30 20:37 ` [PATCH 3/8] Documentation: sysrq: Crutcher Dunnavant is unavailable Randy Dunlap
2012-03-30 23:01 ` Linus Torvalds
2012-03-30 20:37 ` [PATCH 4/8] Documentation: CodingStyle: add inline assembly guidelines Randy Dunlap
2012-03-30 20:37 ` [PATCH 5/8] Documentation: input.txt: clarify mousedev 'cat' command syntax Randy Dunlap
2012-03-30 20:37 ` [PATCH 6/8] Documentation: remove references to /etc/modprobe.conf Randy Dunlap
2012-03-30 20:37 ` Randy Dunlap [this message]
2012-03-30 20:37 ` [PATCH 8/8] Documentation: fix typo in ABI/stable/sysfs-driver-usb-usbtmc Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F761980.4050307@xenotime.net \
--to=rdunlap@xenotime.net \
--cc=linux-kernel@vger.kernel.org \
--cc=lucas.demarchi@profusion.mobi \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox