public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Richard Weinberger <richard@nod.at>
To: Phillip Lougher <plougher@redhat.com>
Cc: linux-kernel@vger.kernel.org,
	Andrew Morton <akpm@linux-foundation.org>,
	Dan Rosenberg <drosenberg@vsecurity.com>,
	"Serge E. Hallyn" <serge@hallyn.com>,
	Eugene Teo <eteo@redhat.com>, Eric Paris <eparis@redhat.com>,
	James Morris <jmorris@namei.org>,
	Kees Cook <keescook@chromium.org>
Subject: Re: [PATCH] sysctl: fix restrict write access to dmesg_restrict
Date: Sat, 31 Mar 2012 01:50:52 +0200	[thread overview]
Message-ID: <4F7646DC.8090802@nod.at> (raw)
In-Reply-To: <20120330234317.GC411@lenovo-rd230-04.lab.bos.redhat.com>

[-- Attachment #1: Type: text/plain, Size: 454 bytes --]

Am 31.03.2012 01:43, schrieb Phillip Lougher:
> Commit bfdc0b4 adds code to restrict access to dmesg_restrict,
> however, it incorrectly alters kptr_restrict rather than
> dmesg_restrict.
> 
> The original patch from Richard Weinberger
> (https://lkml.org/lkml/2011/3/14/362) alters dmesg_restrict as
> expected, and so the patch seems to have been misapplied.
> 

Hmm, indeed.
Any idea how this could happen, Andrew?

Thanks,
//richard


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 490 bytes --]

  reply	other threads:[~2012-03-30 23:51 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-30 23:43 [PATCH] sysctl: fix restrict write access to dmesg_restrict Phillip Lougher
2012-03-30 23:50 ` Richard Weinberger [this message]
2012-03-31  0:55   ` Andrew Morton
2012-03-31  1:58     ` Phillip Lougher
2012-03-31 16:13       ` Greg Kroah-Hartman
2012-04-01  2:10 ` Kees Cook
2012-04-04  2:30   ` Serge E. Hallyn
2012-04-04 18:40     ` [PATCH] sysctl: fix write access to dmesg_restrict/kptr_restrict Kees Cook
2012-04-04 19:07       ` Richard Weinberger
2012-04-04 21:27       ` Serge E. Hallyn
2012-04-04 21:43         ` Kees Cook
2012-04-05  5:11       ` James Morris

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F7646DC.8090802@nod.at \
    --to=richard@nod.at \
    --cc=akpm@linux-foundation.org \
    --cc=drosenberg@vsecurity.com \
    --cc=eparis@redhat.com \
    --cc=eteo@redhat.com \
    --cc=jmorris@namei.org \
    --cc=keescook@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=plougher@redhat.com \
    --cc=serge@hallyn.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox