From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753680Ab2CaVxO (ORCPT ); Sat, 31 Mar 2012 17:53:14 -0400 Received: from mail-bk0-f46.google.com ([209.85.214.46]:41363 "EHLO mail-bk0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753127Ab2CaVxM (ORCPT ); Sat, 31 Mar 2012 17:53:12 -0400 Message-ID: <4F777C6F.2070603@mvista.com> Date: Sun, 01 Apr 2012 01:51:43 +0400 From: Sergei Shtylyov User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:11.0) Gecko/20120327 Thunderbird/11.0.1 MIME-Version: 1.0 To: Nicolas Ferre CC: linux-arm-kernel@lists.infradead.org, linux-usb@vger.kernel.org, plagnioj@jcrosoft.com, ludovic.desroches@atmel.com, linux-kernel@vger.kernel.org, arnd@arndb.de, olof@lixom.net Subject: Re: [PATCH 03/12] ARM: at91/USB host: specify and handle properly vbus_pin_active_low References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello. On 29-03-2012 17:27, Nicolas Ferre wrote: > Due to an error while handling vbus_pin_active_low in ohci-at91 driver, > the specification of this property was not good in devices/board files. > Signed-off-by: Nicolas Ferre > Acked-by: Jean-Christophe PLAGNIOL-VILLARD > Cc: stable [3.2+] > --- > arch/arm/mach-at91/at91sam9263_devices.c | 3 ++- > arch/arm/mach-at91/at91sam9g45_devices.c | 6 ++++-- > arch/arm/mach-at91/board-sam9263ek.c | 1 + > arch/arm/mach-at91/board-sam9m10g45ek.c | 1 + > 4 files changed, 8 insertions(+), 3 deletions(-) > > diff --git a/arch/arm/mach-at91/at91sam9263_devices.c b/arch/arm/mach-at91/at91sam9263_devices.c > index 53688c4..5cdca89d 100644 > --- a/arch/arm/mach-at91/at91sam9263_devices.c > +++ b/arch/arm/mach-at91/at91sam9263_devices.c > @@ -72,7 +72,8 @@ void __init at91_add_device_usbh(struct at91_usbh_data *data) > /* Enable VBus control for UHP ports */ > for (i = 0; i< data->ports; i++) { > if (gpio_is_valid(data->vbus_pin[i])) > - at91_set_gpio_output(data->vbus_pin[i], 0); > + at91_set_gpio_output(data->vbus_pin[i], > + data->vbus_pin_active_low[i] ^ 0); Note that XOR with 0 is a nop, left operand doesn't change its value. WBR, Sergei