From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753394Ab2DBRQG (ORCPT ); Mon, 2 Apr 2012 13:16:06 -0400 Received: from wolverine02.qualcomm.com ([199.106.114.251]:7606 "EHLO wolverine02.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751548Ab2DBRQE (ORCPT ); Mon, 2 Apr 2012 13:16:04 -0400 X-IronPort-AV: E=McAfee;i="5400,1158,6668"; a="175817430" Message-ID: <4F79DED3.4070007@codeaurora.org> Date: Mon, 02 Apr 2012 10:16:03 -0700 From: Stephen Boyd User-Agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:8.0) Gecko/20111105 Thunderbird/8.0 MIME-Version: 1.0 To: Russell King - ARM Linux CC: Mark Brown , Mike Turquette , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 2/2] clkdev: Implement managed clk_get() References: <1333279960-8497-1-git-send-email-broonie@opensource.wolfsonmicro.com> <1333279960-8497-2-git-send-email-broonie@opensource.wolfsonmicro.com> <4F787392.5040308@codeaurora.org> <20120401153450.GC8971@opensource.wolfsonmicro.com> <4F79D85F.4020909@codeaurora.org> <20120402165242.GC24211@n2100.arm.linux.org.uk> <4F79DC03.7020503@codeaurora.org> <20120402170858.GG24211@n2100.arm.linux.org.uk> In-Reply-To: <20120402170858.GG24211@n2100.arm.linux.org.uk> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/02/12 10:08, Russell King - ARM Linux wrote: > On Mon, Apr 02, 2012 at 10:04:03AM -0700, Stephen Boyd wrote: >> On 04/02/12 09:52, Russell King - ARM Linux wrote: >>> On Mon, Apr 02, 2012 at 09:48:31AM -0700, Stephen Boyd wrote: >>>> I hope we get a better clk_get() implementation with the unified struct >>>> clk. Don't get me wrong, clkdev is a great improvement over open coding >>>> clock framework stuff in each platform. But clkdev is really just >>>> another platform specific implementation >>> Utter crap. It is not platform specific. >> It has compile-time platform hooks so it isn't entirely generic. > Compile time hooks which are necessary to ensure safety of the provided > struct clk. You can't implement a clk_get() which doesn't have either > knowledge of the struct clk or some kind of hook into platform specific > code. That's a hard and unarguable fact. > >>>> that most platforms decide to >>>> use. Each platform has to select the option and it breaks if two >>>> platforms implement __clk_get()/__clk_put() in conflicting ways. >>> They should go away with the common clock stuff: they are there to deal >>> with the implementation specific parts of struct clk, and as the common >>> clock stuff sorts that out, these should be provided by the common clk. >> Agreed. They should all be deleted and only one should exist. > Utter crap. Deleting them makes the non-common clock implementations > unsafe. If a struct clk is provided by a module (and we do have some > which are) then the module reference count has to be held. That's > what these hooks do. > > When these platforms get converted over to the common clock, and the > issues surrounding dynamically registered and removed clocks are sane, > these hooks have to be used by the common clock to deal with the > refcounting so that common code knows when the structures can be freed. I'm saying that when every platform is using the common clock code we would only have one __clk_get() implementation and we should be able to delete clkdev.h entirely. -- Sent by an employee of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.