From: Boris Ostrovsky <boris.ostrovsky@amd.com>
To: Tony Luck <tony.luck@intel.com>
Cc: Len Brown <lenb@kernel.org>, <linux-acpi@vger.kernel.org>,
<linux-pm@lists.linux-foundation.org>,
<linux-kernel@vger.kernel.org>, Len Brown <len.brown@intel.com>
Subject: Re: [PATCH] Use safe_halt() rather than halt() in acpi_idle_play_deay()
Date: Tue, 3 Apr 2012 12:52:19 -0400 [thread overview]
Message-ID: <4F7B2AC3.3060706@amd.com> (raw)
In-Reply-To: <4f7b27487632dad07@agluck-desktop.sc.intel.com>
On 04/03/12 12:37, Luck, Tony: <tony.luck@intel.com wrote:
> ACPI code is shared by arch/x86 and arch/ia64. ia64 doesn't provide a plain
> "halt()" function. Use safe_halt() instead.
>
> Signed-off-by: Tony Luck<tony.luck@intel.com>
>
> ---
>
> E-mail discussion indicated this would be OK. Please check on x86
> before applying.
Tested-by: Boris Ostrovsky <boris.ostrovsky@amd.com>
-boris
>
> diff --git a/drivers/acpi/processor_idle.c b/drivers/acpi/processor_idle.c
> index b3447f6..f3decb3 100644
> --- a/drivers/acpi/processor_idle.c
> +++ b/drivers/acpi/processor_idle.c
> @@ -786,7 +786,7 @@ static int acpi_idle_play_dead(struct cpuidle_device *dev, int index)
> while (1) {
>
> if (cx->entry_method == ACPI_CSTATE_HALT)
> - halt();
> + safe_halt();
> else if (cx->entry_method == ACPI_CSTATE_SYSTEMIO) {
> inb(cx->address);
> /* See comment in acpi_idle_do_entry() */
>
next parent reply other threads:[~2012-04-03 16:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <4f7b27487632dad07@agluck-desktop.sc.intel.com>
2012-04-03 16:52 ` Boris Ostrovsky [this message]
2012-04-05 17:43 ` [PATCH] Use safe_halt() rather than halt() in acpi_idle_play_deay() Len Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F7B2AC3.3060706@amd.com \
--to=boris.ostrovsky@amd.com \
--cc=len.brown@intel.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox