From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755445Ab2DCSIQ (ORCPT ); Tue, 3 Apr 2012 14:08:16 -0400 Received: from usmamail.tilera.com ([206.83.70.75]:44500 "EHLO USMAMAIL.TILERA.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754133Ab2DCSIO (ORCPT ); Tue, 3 Apr 2012 14:08:14 -0400 Message-ID: <4F7B3C8B.9010609@tilera.com> Date: Tue, 3 Apr 2012 14:08:11 -0400 From: Chris Metcalf User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:11.0) Gecko/20120327 Thunderbird/11.0.1 MIME-Version: 1.0 To: Joe Perches CC: Kautuk Consul , "David S. Miller" , Linux Kernel Mailing List Subject: Re: CodingStyle vs checkpatch for block comments References: <1333195539-5421-1-git-send-email-consul.kautuk@gmail.com> <4F7B2114.4000806@tilera.com> <4F7B21FB.3040609@tilera.com> <4F7B2766.9080208@tilera.com> <1333471474.26079.43.camel@joe2Laptop> <4F7B2AA7.5010906@tilera.com> <1333472391.26079.47.camel@joe2Laptop> <4F7B32A0.1020009@tilera.com> <1333474907.26079.57.camel@joe2Laptop> In-Reply-To: <1333474907.26079.57.camel@joe2Laptop> X-Enigmail-Version: 1.4 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/3/2012 1:41 PM, Joe Perches wrote: > On Tue, 2012-04-03 at 13:25 -0400, Chris Metcalf wrote: >> The relevant code in checkpatch.pl is: >> >> if ($rawline =~ /^\+[ \t]*\/\*[ \t]*$/ && >> $prevrawline =~ /^\+[ \t]*$/) { >> CHK("BLOCK_COMMENT_STYLE", >> "Don't begin block comments with only a /* >> line, use /* comment...\n" . $hereprev); >> } >> >> So, my questions - >> >> 1. I'm not sure what the regexps are really trying to avoid. Presumably a >> blank line followed by a block comment is OK? Certainly the kernel sources >> are full of this construct. > It emits a check message on > > /* > > but not > > /* some actual comment Right, I understand what the regexps do, I'm just not clear on what the rationale is. Is it trying to ensure that multi-line block comments are never preceded by a blank line? Is it trying to change the format of block comments such that they either are preceded by a blank line, or a standalone "/*", but not both? Confusing. >> 2. The actual warning message emitted seems to directly contradict the >> CodingStyle document, so presumably we should either clarify the message, >> or update CodingStyle if we're really trying to change the style. > Or just remove it or add a test for the patched file > to be in net/... or drivers/net... or something. Obviously removing it would be an easy fix. :-) I don't know if it makes sense to advocate for different kernel comment styles in different subtrees. -- Chris Metcalf, Tilera Corp. http://www.tilera.com