From: Jens Axboe <axboe@kernel.dk>
To: Tao Guo <glorioustao@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, neilb@suse.de, axboe@fusionio.com
Subject: Re: [PATCH] umem: fix up unplugging.
Date: Wed, 04 Apr 2012 17:18:33 -0600 [thread overview]
Message-ID: <4F7CD6C9.4060509@kernel.dk> (raw)
In-Reply-To: <CAAV8rn+T7FM7bG+Q6fyoUrVtzOkYOx94Nh87Rg12UqCdk9HhWQ@mail.gmail.com>
On 2012-04-04 16:20, Tao Guo wrote:
> Hi Andrew,
>
> Thanks for your reply.
>
> Yes, without this patch the umem driver just doesn't work.
> It is a bug introduced by commit 7eaceaccab5f40bbfda044629a6298616aeaed50.
> In that patch, Jens removed the whole mm_unplug_device() function,
> which used to be
> the trigger to make umem start to work.
Hmm indeed, that's isn't terribly useful. Why aren't we just calling
activate_card() on addition of a bio?
But your patch looks fine too, if it's tested it beats what we have.
--
Jens Axboe
next prev parent reply other threads:[~2012-04-04 23:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-30 14:17 [PATCH] umem: fix up unplugging Tao Guo
2012-04-04 21:46 ` Andrew Morton
2012-04-04 22:20 ` Tao Guo
2012-04-04 23:18 ` Jens Axboe [this message]
2012-04-04 23:58 ` Tao Guo
2012-04-05 23:51 ` Jens Axboe
2012-04-06 4:09 ` Tao Guo
2012-04-06 4:19 ` Jens Axboe
2012-04-06 16:31 ` Tao Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F7CD6C9.4060509@kernel.dk \
--to=axboe@kernel.dk \
--cc=akpm@linux-foundation.org \
--cc=axboe@fusionio.com \
--cc=glorioustao@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=neilb@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox