From: Laxman Dewangan <ldewangan@nvidia.com>
To: Axel Lin <axel.lin@gmail.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Liam Girdwood <lrg@ti.com>,
Mark Brown <broonie@opensource.wolfsonmicro.com>
Subject: Re: [PATCH RFT 2/2] regulator: Convert rc5t583 to set_voltage
Date: Thu, 5 Apr 2012 12:31:44 +0530 [thread overview]
Message-ID: <4F7D4358.50000@nvidia.com> (raw)
In-Reply-To: <1333606056.18055.3.camel@phoenix>
On Thursday 05 April 2012 11:37 AM, Axel Lin wrote:
> Not every regulator driver should implement set_voltage_sel callback.
> See commit e8eef82
> "regulator: Provide a selector based set_voltage_sel() operation".
>
> For rc5t583, the regulator voltage can be mapped onto selector values with a
> simple calculation, thus implement set_voltage is better than set_voltage_sel.
>
> Signed-off-by: Axel Lin<axel.lin@gmail.com>
> ---
I wanted to provide the settling delay whenever voltage output get
change as per datasheet. In place of having this delay in the driver, I
wanted to use implementation of core and for this I need to implement
set_voltage_sel() not set_voltage().
next prev parent reply other threads:[~2012-04-05 7:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-05 6:04 [PATCH 1/2] regulator: rc5t583: Remove nsteps from struct rc5t583_regulator_info Axel Lin
2012-04-05 6:07 ` [PATCH RFT 2/2] regulator: Convert rc5t583 to set_voltage Axel Lin
2012-04-05 7:01 ` Laxman Dewangan [this message]
2012-04-05 9:47 ` Mark Brown
2012-04-06 17:32 ` Mark Brown
2012-04-05 6:58 ` [PATCH 1/2] regulator: rc5t583: Remove nsteps from struct rc5t583_regulator_info Laxman Dewangan
2012-04-05 10:07 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F7D4358.50000@nvidia.com \
--to=ldewangan@nvidia.com \
--cc=axel.lin@gmail.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox