From: Boris Ostrovsky <boris.ostrovsky@amd.com>
To: Jiri Slaby <jslaby@suse.cz>, Len Brown <len.brown@intel.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
the arch/x86 maintainers <x86@kernel.org>,
Jiri Slaby <jirislaby@gmail.com>, Toshi Kani <toshi.kani@hp.com>
Subject: Re: BUG at cpuidle_play_dead
Date: Thu, 5 Apr 2012 17:11:06 -0400 [thread overview]
Message-ID: <4F7E0A6A.40204@amd.com> (raw)
In-Reply-To: <4F7E0884.5090602@suse.cz>
On 04/05/12 17:03, Jiri Slaby wrote:
> Hi,
>
> I'm hitting this BUG as the last thing during shutdown:
> BUG: unable to handle kernel NULL pointer dereference at 00000000000002d8
> IP: [<ffffffff814ab60d>] cpuidle_play_dead+0x1d/0xb0
>
>
> It's because drv is NULL. The problem is gone if I do this:
> --- a/drivers/cpuidle/cpuidle.c
> +++ b/drivers/cpuidle/cpuidle.c
> @@ -83,6 +83,11 @@ int cpuidle_play_dead(void)
> int i, dead_state = -1;
> int power_usage = -1;
>
> + if (!drv) {
> + printk("DRIVER IS NULL\n");
> + return -ENODEV;
> + }
> +
> /* Find lowest-power state that supports long-term idle */
> for (i = CPUIDLE_DRIVER_STATE_START; i< drv->state_count; i++) {
> struct cpuidle_state *s =&drv->states[i];
>
> thanks,
This was already fixed in https://lkml.org/lkml/2012/3/31/249.
Len, please apply that patch.
Thanks.
-boris
prev parent reply other threads:[~2012-04-05 21:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-05 21:03 BUG at cpuidle_play_dead Jiri Slaby
2012-04-05 21:11 ` Boris Ostrovsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F7E0A6A.40204@amd.com \
--to=boris.ostrovsky@amd.com \
--cc=jirislaby@gmail.com \
--cc=jslaby@suse.cz \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=toshi.kani@hp.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox