From: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
To: Sasikantha babu <sasikanth.v19@gmail.com>
Cc: Ananth N Mavinakayanahalli <ananth@in.ibm.com>,
Anil S Keshavamurthy <anil.s.keshavamurthy@intel.com>,
"David S. Miller" <davem@davemloft.net>,
linux-kernel@vger.kernel.org, yrl.pp-manager.tt@hitachi.com
Subject: Re: [PATCH] Kprobes : Recursively remove the directory on failure
Date: Fri, 06 Apr 2012 16:53:12 +0900 [thread overview]
Message-ID: <4F7EA0E8.1070809@hitachi.com> (raw)
In-Reply-To: <1333467303-20130-1-git-send-email-sasikanth.v19@gmail.com>
(2012/04/04 0:35), Sasikantha babu wrote:
> Remove the "kprobes" directory recursivly if "enabled" file creation fails
>
> Signed-off-by: Sasikantha babu <sasikanth.v19@gmail.com>
Right, this should remove recursively, because there is
"list" file already.
Thank you!
Acked-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
> ---
> kernel/kprobes.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/kernel/kprobes.c b/kernel/kprobes.c
> index c62b854..9b45515 100644
> --- a/kernel/kprobes.c
> +++ b/kernel/kprobes.c
> @@ -2251,7 +2251,7 @@ static int __kprobes debugfs_kprobe_init(void)
> file = debugfs_create_file("enabled", 0600, dir,
> &value, &fops_kp);
> if (!file) {
> - debugfs_remove(dir);
> + debugfs_remove_recursive(dir);
> return -ENOMEM;
> }
>
--
Masami HIRAMATSU
Software Platform Research Dept. Linux Technology Center
Hitachi, Ltd., Yokohama Research Laboratory
E-mail: masami.hiramatsu.pt@hitachi.com
prev parent reply other threads:[~2012-04-06 7:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-03 15:35 [PATCH] Kprobes : Recursively remove the directory on failure Sasikantha babu
2012-04-06 7:53 ` Masami Hiramatsu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F7EA0E8.1070809@hitachi.com \
--to=masami.hiramatsu.pt@hitachi.com \
--cc=ananth@in.ibm.com \
--cc=anil.s.keshavamurthy@intel.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=sasikanth.v19@gmail.com \
--cc=yrl.pp-manager.tt@hitachi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox