From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932499Ab2DFWDd (ORCPT ); Fri, 6 Apr 2012 18:03:33 -0400 Received: from masquerade.micron.com ([137.201.242.130]:18792 "EHLO masquerade.micron.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758166Ab2DFWDc (ORCPT ); Fri, 6 Apr 2012 18:03:32 -0400 Message-ID: <4F7F682C.9050806@micron.com> Date: Fri, 6 Apr 2012 15:03:24 -0700 From: Asai Thambi S P User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:11.0) Gecko/20120327 Thunderbird/11.0.1 MIME-Version: 1.0 To: Greg KH CC: Jens Axboe , "linux-kernel@vger.kernel.org" , Sam Bradshaw Subject: Re: [PATCH 2/5] mtip32xx: Add new sysfs entry 'status' and fix restart port References: <4F7E07DC.50909@micron.com> <20120406011037.GA25892@kroah.com> <4F7F322B.6060805@micron.com> <4F7F615B.80305@micron.com> <20120406214426.GA12772@kroah.com> In-Reply-To: <20120406214426.GA12772@kroah.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit X-TM-AS-Product-Ver: SMEX-10.0.0.4152-6.000.1038-18810.005 X-TM-AS-Result: No--25.431100-0.000000-31 X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-MT-CheckInternalSenderRule: True Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/6/2012 2:44 PM, Greg KH wrote: > On Fri, Apr 06, 2012 at 02:34:19PM -0700, Asai Thambi S P wrote: >> On 4/6/2012 11:12 AM, Asai Thambi S P wrote: >> >>> On 4/5/2012 6:10 PM, Greg KH wrote: >>> >>>> On Thu, Apr 05, 2012 at 02:00:12PM -0700, Asai Thambi S P wrote: >>>>> >>>>> * Add support for detecting the following device status >>>>> - write protect >>>>> - over temp (thermal shutdown) >>>>> * New sysfs entry 'status' created for this device, possible values - online, write_protect, thermal_shutdown >>>> >>>> All new (and existing) sysfs files must be documented in >>>> Documentation/ABI/ please do so for these new ones when you add them to >>>> the kernel. >>> >>> >>> I was not aware of this. Thanks. I will a add new file for mtip32xx driver. >>> >> >> >> Greg, >> >> The sysfs entry for the disk is >> /sys/block/rssda -> ../devices/pci0000:00/0000:00:01.0/0000:01:00.0/block/rssda >> >> Should I use /sys/block// or >> /sys/devices/.../block//entry> in the doc file? > > What do the existing api files show for block devices? > I was looking into sysfs-driver-* files to create sysfs-driver-mtip32xx. These files have paths like /sys/bus/pci/*, /sys/devices/*, /sys/class/bluetooth/*, etc. There are sysfs-block-dm and sysfs-block-zram files with /sys/block/dm-/dm/* and /sys/block/zram/*. If I have to follow these, then the file would be sysfs-driver-rssd with /sys/block//*. Let me know. -- Regards, Asai Thambi