From: Glauber Costa <glommer@parallels.com>
To: Tejun Heo <tj@kernel.org>, Li Zefan <lizefan@huawei.com>,
Paul Turner <pjt@google.com>, <cgroups@vger.kernel.org>,
"devel@openvz.org" <devel@openvz.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: bind() call in cgroup's css structure
Date: Mon, 9 Apr 2012 10:59:56 -0300 [thread overview]
Message-ID: <4F82EB5C.7090003@parallels.com> (raw)
Hello Tejun,
During your cgroup refactor, I was wondering if you have any plans to
get rid of the bind() callback that is called when hierarchies are moved?
At least in tree, there seems to be no users for that.
I actually planned to use it myself, to start or remove a jump label
when cpuacct and cpu cgroups were comounted.
Problem is, because we have some calls in the cpuset cgroup from inside
the cpu hotplug handler, we end up taking the almighty cgroup_mutex from
inside the cpu_hotplug.lock.
jump labels take it in most arches through the get_online_cpus()
function call. This means we effectively can't apply jump labels with
the cgroup_mutex held, which is the case throughout the whole bind() call.
All that explained, I figured I might as well ask before I attempted a
solution to that myself: as much as populate(), bind seems to be one of
the overly complicated callbacks, designed for a scenario in which
everything can come and go at will, which is something we're trying to fix.
thanks in advance for your answer!
next reply other threads:[~2012-04-09 14:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-09 13:59 Glauber Costa [this message]
2012-04-09 18:09 ` bind() call in cgroup's css structure Tejun Heo
2012-04-10 0:59 ` Li Zefan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F82EB5C.7090003@parallels.com \
--to=glommer@parallels.com \
--cc=cgroups@vger.kernel.org \
--cc=devel@openvz.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=pjt@google.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox