* [PATCH] scsi: make struct scsi_varlen_cdb_hdr packed
@ 2012-04-10 12:38 James Hogan
0 siblings, 0 replies; only message in thread
From: James Hogan @ 2012-04-10 12:38 UTC (permalink / raw)
To: James E.J. Bottomley, linux-scsi, linux-kernel
The struct scsi_varlen_cdb_hdr is expected to be exactly 10 bytes when
used in struct osd_cdb_head, but it isn't marked as packed. Some
architectures will round the struct size up which triggers BUILD_BUG_ON
compile errors in osd_initiator.c when the outer structs are unexpected
sizes. This is fixed by marking struct scsi_varlen_cdb_hdr as __packed.
Signed-off-by: James Hogan <james.hogan@imgtec.com>
---
include/scsi/scsi.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/include/scsi/scsi.h b/include/scsi/scsi.h
index f34a5a8..c75c8c8 100644
--- a/include/scsi/scsi.h
+++ b/include/scsi/scsi.h
@@ -196,7 +196,7 @@ struct scsi_varlen_cdb_hdr {
__u8 additional_cdb_length; /* total cdb length - 8 */
__be16 service_action;
/* service specific data follows */
-};
+} __packed;
static inline unsigned
scsi_varlen_cdb_length(const void *hdr)
--
1.7.7.6
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2012-04-10 12:56 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-04-10 12:38 [PATCH] scsi: make struct scsi_varlen_cdb_hdr packed James Hogan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox