From: MR Swami Reddy <MR.Swami.Redy@ti.com>
To: Axel Lin <axel.lin@gmail.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Girdwood, Liam" <lrg@ti.com>,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>
Subject: Re: [PATCH RESEND] ASoC: Fix setting aif_val in lm49453_set_dai_fmt
Date: Tue, 10 Apr 2012 19:38:53 +0530 [thread overview]
Message-ID: <4F843EF5.6020507@ti.com> (raw)
In-Reply-To: <1333972124.2569.3.camel@phoenix>
This issues was fixed last week itself.
URL for the patch -
http://mailman.alsa-project.org/pipermail/alsa-devel/2012-April/050967.html
Thanks
Swami
On Monday 09 April 2012 05:18 PM, Axel Lin wrote:
> CBS/CBM/CFS/CFM settings are controlled by BIT[3:4] of 0x60h
>
> for example, for SND_SOC_DAIFMT_CBS_CFS: what we want is to clear both BIT[3:4].
>
> aif_val = ~LM49453_AUDIO_PORT1_BASIC_CLK_MS | ~LM49453_AUDIO_PORT1_BASIC_SYNC_MS;
> actually set both bits.
>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
> ---
> Seems the my mail failed to reach alsa mailing list.
> I resend to LKML instead.
>
> Axel
> sound/soc/codecs/lm49453.c | 8 ++------
> 1 files changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/sound/soc/codecs/lm49453.c b/sound/soc/codecs/lm49453.c
> index 744063d..a25e80a 100644
> --- a/sound/soc/codecs/lm49453.c
> +++ b/sound/soc/codecs/lm49453.c
> @@ -1185,16 +1185,12 @@ static int lm49453_set_dai_fmt(struct snd_soc_dai *codec_dai, unsigned int fmt)
>
> switch (fmt & SND_SOC_DAIFMT_MASTER_MASK) {
> case SND_SOC_DAIFMT_CBS_CFS:
> - aif_val = ~LM49453_AUDIO_PORT1_BASIC_CLK_MS |
> - ~LM49453_AUDIO_PORT1_BASIC_SYNC_MS;
> break;
> case SND_SOC_DAIFMT_CBS_CFM:
> - aif_val = ~LM49453_AUDIO_PORT1_BASIC_CLK_MS |
> - LM49453_AUDIO_PORT1_BASIC_SYNC_MS;
> + aif_val = LM49453_AUDIO_PORT1_BASIC_SYNC_MS;
> break;
> case SND_SOC_DAIFMT_CBM_CFS:
> - aif_val = LM49453_AUDIO_PORT1_BASIC_CLK_MS |
> - ~LM49453_AUDIO_PORT1_BASIC_SYNC_MS;
> + aif_val = LM49453_AUDIO_PORT1_BASIC_CLK_MS;
> break;
> case SND_SOC_DAIFMT_CBM_CFM:
> aif_val = LM49453_AUDIO_PORT1_BASIC_CLK_MS |
> --
> 1.7.5.4
>
>
>
prev parent reply other threads:[~2012-04-10 14:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-09 11:48 [PATCH RESEND] ASoC: Fix setting aif_val in lm49453_set_dai_fmt Axel Lin
2012-04-10 14:08 ` MR Swami Reddy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F843EF5.6020507@ti.com \
--to=mr.swami.redy@ti.com \
--cc=alsa-devel@alsa-project.org \
--cc=axel.lin@gmail.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox