* [PATCH RESEND] ASoC: Fix setting aif_val in lm49453_set_dai_fmt
@ 2012-04-09 11:48 Axel Lin
2012-04-10 14:08 ` MR Swami Reddy
0 siblings, 1 reply; 2+ messages in thread
From: Axel Lin @ 2012-04-09 11:48 UTC (permalink / raw)
To: linux-kernel; +Cc: M R Swami Reddy, Liam Girdwood, Mark Brown, alsa-devel
CBS/CBM/CFS/CFM settings are controlled by BIT[3:4] of 0x60h
for example, for SND_SOC_DAIFMT_CBS_CFS: what we want is to clear both BIT[3:4].
aif_val = ~LM49453_AUDIO_PORT1_BASIC_CLK_MS | ~LM49453_AUDIO_PORT1_BASIC_SYNC_MS;
actually set both bits.
Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
Seems the my mail failed to reach alsa mailing list.
I resend to LKML instead.
Axel
sound/soc/codecs/lm49453.c | 8 ++------
1 files changed, 2 insertions(+), 6 deletions(-)
diff --git a/sound/soc/codecs/lm49453.c b/sound/soc/codecs/lm49453.c
index 744063d..a25e80a 100644
--- a/sound/soc/codecs/lm49453.c
+++ b/sound/soc/codecs/lm49453.c
@@ -1185,16 +1185,12 @@ static int lm49453_set_dai_fmt(struct snd_soc_dai *codec_dai, unsigned int fmt)
switch (fmt & SND_SOC_DAIFMT_MASTER_MASK) {
case SND_SOC_DAIFMT_CBS_CFS:
- aif_val = ~LM49453_AUDIO_PORT1_BASIC_CLK_MS |
- ~LM49453_AUDIO_PORT1_BASIC_SYNC_MS;
break;
case SND_SOC_DAIFMT_CBS_CFM:
- aif_val = ~LM49453_AUDIO_PORT1_BASIC_CLK_MS |
- LM49453_AUDIO_PORT1_BASIC_SYNC_MS;
+ aif_val = LM49453_AUDIO_PORT1_BASIC_SYNC_MS;
break;
case SND_SOC_DAIFMT_CBM_CFS:
- aif_val = LM49453_AUDIO_PORT1_BASIC_CLK_MS |
- ~LM49453_AUDIO_PORT1_BASIC_SYNC_MS;
+ aif_val = LM49453_AUDIO_PORT1_BASIC_CLK_MS;
break;
case SND_SOC_DAIFMT_CBM_CFM:
aif_val = LM49453_AUDIO_PORT1_BASIC_CLK_MS |
--
1.7.5.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH RESEND] ASoC: Fix setting aif_val in lm49453_set_dai_fmt
2012-04-09 11:48 [PATCH RESEND] ASoC: Fix setting aif_val in lm49453_set_dai_fmt Axel Lin
@ 2012-04-10 14:08 ` MR Swami Reddy
0 siblings, 0 replies; 2+ messages in thread
From: MR Swami Reddy @ 2012-04-10 14:08 UTC (permalink / raw)
To: Axel Lin
Cc: linux-kernel@vger.kernel.org, Girdwood, Liam, Mark Brown,
alsa-devel@alsa-project.org
This issues was fixed last week itself.
URL for the patch -
http://mailman.alsa-project.org/pipermail/alsa-devel/2012-April/050967.html
Thanks
Swami
On Monday 09 April 2012 05:18 PM, Axel Lin wrote:
> CBS/CBM/CFS/CFM settings are controlled by BIT[3:4] of 0x60h
>
> for example, for SND_SOC_DAIFMT_CBS_CFS: what we want is to clear both BIT[3:4].
>
> aif_val = ~LM49453_AUDIO_PORT1_BASIC_CLK_MS | ~LM49453_AUDIO_PORT1_BASIC_SYNC_MS;
> actually set both bits.
>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
> ---
> Seems the my mail failed to reach alsa mailing list.
> I resend to LKML instead.
>
> Axel
> sound/soc/codecs/lm49453.c | 8 ++------
> 1 files changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/sound/soc/codecs/lm49453.c b/sound/soc/codecs/lm49453.c
> index 744063d..a25e80a 100644
> --- a/sound/soc/codecs/lm49453.c
> +++ b/sound/soc/codecs/lm49453.c
> @@ -1185,16 +1185,12 @@ static int lm49453_set_dai_fmt(struct snd_soc_dai *codec_dai, unsigned int fmt)
>
> switch (fmt & SND_SOC_DAIFMT_MASTER_MASK) {
> case SND_SOC_DAIFMT_CBS_CFS:
> - aif_val = ~LM49453_AUDIO_PORT1_BASIC_CLK_MS |
> - ~LM49453_AUDIO_PORT1_BASIC_SYNC_MS;
> break;
> case SND_SOC_DAIFMT_CBS_CFM:
> - aif_val = ~LM49453_AUDIO_PORT1_BASIC_CLK_MS |
> - LM49453_AUDIO_PORT1_BASIC_SYNC_MS;
> + aif_val = LM49453_AUDIO_PORT1_BASIC_SYNC_MS;
> break;
> case SND_SOC_DAIFMT_CBM_CFS:
> - aif_val = LM49453_AUDIO_PORT1_BASIC_CLK_MS |
> - ~LM49453_AUDIO_PORT1_BASIC_SYNC_MS;
> + aif_val = LM49453_AUDIO_PORT1_BASIC_CLK_MS;
> break;
> case SND_SOC_DAIFMT_CBM_CFM:
> aif_val = LM49453_AUDIO_PORT1_BASIC_CLK_MS |
> --
> 1.7.5.4
>
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-04-10 14:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-04-09 11:48 [PATCH RESEND] ASoC: Fix setting aif_val in lm49453_set_dai_fmt Axel Lin
2012-04-10 14:08 ` MR Swami Reddy
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox