From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1759299Ab2DJPM7 (ORCPT <rfc822;w@1wt.eu>);
	Tue, 10 Apr 2012 11:12:59 -0400
Received: from avon.wwwdotorg.org ([70.85.31.133]:33376 "EHLO
	avon.wwwdotorg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1759089Ab2DJPM5 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 10 Apr 2012 11:12:57 -0400
Message-ID: <4F844DF6.9010809@wwwdotorg.org>
Date: Tue, 10 Apr 2012 09:12:54 -0600
From: Stephen Warren <swarren@wwwdotorg.org>
User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.28) Gecko/20120313 Thunderbird/3.1.20
MIME-Version: 1.0
To: Linus Walleij <linus.walleij@linaro.org>
CC: Stephen Rothwell <sfr@canb.auug.org.au>, linux-next@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: linux-next: build failure after merge of the pinctrl tree
References: <20120404124437.ff05ebcc4db98109d5fcee22@canb.auug.org.au>	<4F7BC36E.4070000@wwwdotorg.org> <CACRpkdY57hQOvpqxaaYyJoH0ewfOAj9RqzWtC=aOWQyNMoG6fg@mail.gmail.com>
In-Reply-To: <CACRpkdY57hQOvpqxaaYyJoH0ewfOAj9RqzWtC=aOWQyNMoG6fg@mail.gmail.com>
X-Enigmail-Version: 1.1.2
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 04/10/2012 01:42 AM, Linus Walleij wrote:
> On Wed, Apr 4, 2012 at 5:43 AM, Stephen Warren <swarren@wwwdotorg.org> wrote:
>> On 04/03/2012 08:44 PM, Stephen Rothwell wrote:
>>> Hi Linus,
>>>
>>> After merging the pinctrl tree, today's linux-next build (powerpc
>>> ppc64_defconfig) failed like this:
>>>
>>> drivers/pinctrl/devicetree.c: In function 'dt_free_map':
>>> drivers/pinctrl/devicetree.c:44:42: error: dereferencing pointer to
>>> incomplete type drivers/pinctrl/devicetree.c:45:6: error:
>>> dereferencing pointer to incomplete type
>>> drivers/pinctrl/devicetree.c: In function 'dt_to_map_one_config':
>>> drivers/pinctrl/devicetree.c:140:21: error: dereferencing pointer
>>> to incomplete type drivers/pinctrl/devicetree.c:141:10: error:
>>> dereferencing pointer to incomplete type
>>> drivers/pinctrl/devicetree.c:146:11: error: dereferencing pointer
>>> to incomplete type
>>
>> This doesn't repro for me with tegra_defconfig, which has both
>> CONFIG_PINCTRL and CONFIG_OF enabled.
>>
>> I believe this happens because of the following in
>> drivers/pinctrl/Makefile:
>>
>> obj-$(CONFIG_OF)                += devicetree.o
>>
>> On ppc64, CONFIG_OF is probably true, yet the rest of PINCTRL isn't
>> enabled, hence the headers that are included probably don't declare
>> all the types needed to compile that file.
>>
>> In fact, the file shouldn't be compiled, since it's not needed if
>> !CONFIG_PINCTRL. So perhaps the Makefile should be more like:
>>
>> ifeq ($(CONFIG_OF),y)
>> obj-$(CONFIG_PINCTRL)           += devicetree.o
>> endif
> 
> Easiest fixed with a new Kconfig like CONFIG_PINCTRL_OF that
> depend on both right?
> 
> I'll cook a patch.

I don't think so; why wouldn't pinctrl automatically have DT support
when both pinctrl and OF are enabled. BTW, I already posted a patch to
fix this last week.