From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759249Ab2DJTZM (ORCPT ); Tue, 10 Apr 2012 15:25:12 -0400 Received: from comal.ext.ti.com ([198.47.26.152]:54055 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755368Ab2DJTZL (ORCPT ); Tue, 10 Apr 2012 15:25:11 -0400 Message-ID: <4F84890A.30500@ti.com> Date: Tue, 10 Apr 2012 14:24:58 -0500 From: Jon Hunter User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:11.0) Gecko/20120329 Thunderbird/11.0.1 MIME-Version: 1.0 To: Afzal Mohammed CC: , , , , , , , , , , , , , , Subject: Re: [PATCH v3 4/9] ARM: OMAP2+: gpmc-nand: populate gpmc configs References: <6c120ab77d0900a6f977246bc58fb37c62280371.1333640054.git.afzal@ti.com> In-Reply-To: <6c120ab77d0900a6f977246bc58fb37c62280371.1333640054.git.afzal@ti.com> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [192.157.144.139] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Afzal, On 04/05/2012 10:46 AM, Afzal Mohammed wrote: > Currently gpmc is configured in platform for nand. > As configuring gpmc has been moved to gpmc driver, > populate details needed for the driver to configure > gpmc. gpmc driver would configure based on this > information. > > Signed-off-by: Afzal Mohammed > --- > arch/arm/mach-omap2/gpmc-nand.c | 97 ++++++++++++++------------------ > arch/arm/plat-omap/include/plat/nand.h | 8 ++- > 2 files changed, 48 insertions(+), 57 deletions(-) > > diff --git a/arch/arm/mach-omap2/gpmc-nand.c b/arch/arm/mach-omap2/gpmc-nand.c > index 386dec8..85de31f 100644 > --- a/arch/arm/mach-omap2/gpmc-nand.c > +++ b/arch/arm/mach-omap2/gpmc-nand.c > @@ -21,24 +21,38 @@ > #include > #include > > -static struct resource gpmc_nand_resource = { > - .flags = IORESOURCE_MEM, > + > +#define GPMC_NAND_CONFIG_NUM 4 Where does 4 come from? Jon