From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932497Ab2DKDRY (ORCPT ); Tue, 10 Apr 2012 23:17:24 -0400 Received: from terminus.zytor.com ([198.137.202.10]:53356 "EHLO mail.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756018Ab2DKDRW (ORCPT ); Tue, 10 Apr 2012 23:17:22 -0400 Message-ID: <4F84F788.3020702@zytor.com> Date: Tue, 10 Apr 2012 20:16:24 -0700 From: "H. Peter Anvin" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:11.0) Gecko/20120329 Thunderbird/11.0.1 MIME-Version: 1.0 To: Will Drewry CC: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-doc@vger.kernel.org, kernel-hardening@lists.openwall.com, netdev@vger.kernel.org, x86@kernel.org, arnd@arndb.de, davem@davemloft.net, mingo@redhat.com, oleg@redhat.com, peterz@infradead.org, rdunlap@xenotime.net, mcgrathr@chromium.org, tglx@linutronix.de, luto@mit.edu, eparis@redhat.com, serge.hallyn@canonical.com, djm@mindrot.org, scarybeasts@gmail.com, indan@nul.nu, pmoore@redhat.com, akpm@linux-foundation.org, corbet@lwn.net, eric.dumazet@gmail.com, markus@chromium.org, coreyb@linux.vnet.ibm.com, keescook@chromium.org Subject: Re: [PATCH v15 04/13] arch/x86: add syscall_get_arch to syscall.h References: <1331781125-15658-1-git-send-email-wad@chromium.org> <1331781125-15658-5-git-send-email-wad@chromium.org> <4F6F7362.6030402@zytor.com> In-Reply-To: X-Enigmail-Version: 1.4 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/10/2012 08:13 PM, Will Drewry wrote: > > Now that I've seen is_ia32_task(), it appears to be exactly the same as above: > (1) If we're x86_32, it's ia32 > (2) If we're x86_64, ia32 == !!(status & TS_COMPAT) > (3) Otherwise, it's x86_64, including x32 > > Am I missing something? Should is_ia32_task(void) take a task_struct? > Right now, I don't see any reason to change the code, as posted, but > maybe I am mis-reading? > is_compat_task() is true for x32, is_ia32_task() is false. -hpa