From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964791Ab2DLNPW (ORCPT ); Thu, 12 Apr 2012 09:15:22 -0400 Received: from ppsw-41.csi.cam.ac.uk ([131.111.8.141]:33244 "EHLO ppsw-41.csi.cam.ac.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757557Ab2DLNPV (ORCPT ); Thu, 12 Apr 2012 09:15:21 -0400 X-Cam-AntiVirus: no malware found X-Cam-SpamDetails: not scanned X-Cam-ScannerInfo: http://www.cam.ac.uk/cs/email/scanner/ Message-ID: <4F86D55F.2030808@cam.ac.uk> Date: Thu, 12 Apr 2012 14:15:11 +0100 From: Jonathan Cameron User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:11.0) Gecko/20120327 Thunderbird/11.0.1 MIME-Version: 1.0 To: Laxman Dewangan CC: gregkh@linuxfoundation.org, grant.likely@secretlab.ca, rob.herring@calxeda.com, jbrenner@taosinc.com, rklein@nvidia.com, max@stro.at, linux-iio@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, devicetree-discuss@lists.ozlabs.org Subject: Re: [PATCH V3 1/2] staging: iio: add channel info for sampling frequency References: <1334234288-25037-1-git-send-email-ldewangan@nvidia.com> <1334234288-25037-2-git-send-email-ldewangan@nvidia.com> In-Reply-To: <1334234288-25037-2-git-send-email-ldewangan@nvidia.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/12/2012 1:38 PM, Laxman Dewangan wrote: > Adding channel info IIO_CHAN_INFO_SAMP_FREQ to select > different sampling frequency per channel wise. > > Signed-off-by: Laxman Dewangan > --- > As per discussion on previous patch, adding channel info > for selecting sampling freqeuncy. To match with the existing devices can we not use the abrieviation for the attribute naming. Other than that, all good. > drivers/staging/iio/iio.h | 5 +++++ > drivers/staging/iio/industrialio-core.c | 1 + > 2 files changed, 6 insertions(+), 0 deletions(-) > > diff --git a/drivers/staging/iio/iio.h b/drivers/staging/iio/iio.h > index b9cd454..9aa0dd5 100644 > --- a/drivers/staging/iio/iio.h > +++ b/drivers/staging/iio/iio.h > @@ -36,6 +36,7 @@ enum iio_chan_info_enum { > IIO_CHAN_INFO_QUADRATURE_CORRECTION_RAW, > IIO_CHAN_INFO_AVERAGE_RAW, > IIO_CHAN_INFO_LOW_PASS_FILTER_3DB_FREQUENCY, > + IIO_CHAN_INFO_SAMP_FREQ, > }; > > #define IIO_CHAN_INFO_SHARED_BIT(type) BIT(type*2) > @@ -81,6 +82,10 @@ enum iio_chan_info_enum { > #define IIO_CHAN_INFO_LOW_PASS_FILTER_3DB_FREQUENCY_SEPARATE_BIT \ > IIO_CHAN_INFO_SEPARATE_BIT( \ > IIO_CHAN_INFO_LOW_PASS_FILTER_3DB_FREQUENCY) > +#define IIO_CHAN_INFO_SAMP_FREQ_SEPARATE_BIT \ > + IIO_CHAN_INFO_SEPARATE_BIT(IIO_CHAN_INFO_SAMP_FREQ) > +#define IIO_CHAN_INFO_SAMP_FREQ_SHARED_BIT \ > + IIO_CHAN_INFO_SHARED_BIT(IIO_CHAN_INFO_SAMP_FREQ) > > enum iio_endian { > IIO_CPU, > diff --git a/drivers/staging/iio/industrialio-core.c b/drivers/staging/iio/industrialio-core.c > index d303bfb..14ce6ce 100644 > --- a/drivers/staging/iio/industrialio-core.c > +++ b/drivers/staging/iio/industrialio-core.c > @@ -90,6 +90,7 @@ static const char * const iio_chan_info_postfix[] = { > [IIO_CHAN_INFO_AVERAGE_RAW] = "mean_raw", > [IIO_CHAN_INFO_LOW_PASS_FILTER_3DB_FREQUENCY] > = "filter_low_pass_3db_frequency", > + [IIO_CHAN_INFO_SAMP_FREQ] = "samp_freq", "sampling_frequency" > }; > > const struct iio_chan_spec