From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762396Ab2DLSvj (ORCPT ); Thu, 12 Apr 2012 14:51:39 -0400 Received: from bear.ext.ti.com ([192.94.94.41]:58547 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754573Ab2DLSvh (ORCPT ); Thu, 12 Apr 2012 14:51:37 -0400 Message-ID: <4F87240F.6060902@ti.com> Date: Thu, 12 Apr 2012 20:50:55 +0200 From: "Cousson, Benoit" Organization: Texas Instruments User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:11.0) Gecko/20120327 Thunderbird/11.0.1 MIME-Version: 1.0 To: Paul Walmsley , "Balbi, Felipe" CC: "Mohammed, Afzal" , Greg KH , "Shilimkar, Santosh" , "V, Aneesh" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-omap@vger.kernel.org" , "mgreer@animalcreek.com" , "msalter@redhat.com" Subject: Re: [PATCH v4 0/7] Add TI EMIF SDRAM controller driver References: <1331934707-29487-1-git-send-email-aneesh@ti.com> <20120412030044.GA26236@kroah.com> <4F867A95.9030104@ti.com> <20120412131045.GB31384@kroah.com> In-Reply-To: Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org + Felipe, Hi Paul, On 4/12/2012 7:00 PM, Paul Walmsley wrote: > Hi > > On Thu, 12 Apr 2012, Mohammed, Afzal wrote: > >> On Thu, Apr 12, 2012 at 18:40:45, Greg KH wrote: >>> On Thu, Apr 12, 2012 at 12:17:49PM +0530, Santosh Shilimkar wrote: >>>> I was hoping that we will have some thing like drivers/memory/* >>>> but since it doesn't exist, we used drivers/misc. >>> >>> Why not create it? I have no objection to that, it makes it more >>> obvious as to what this really is. >> >> There is another memory controller used in a few TI SoCs, >> namely GPMC [1], do you prefer having it too there. >> >> As of now it is not a driver, platform code handles GPMC, a patch >> series for converting it into a driver (but still residing in >> platform folder) was sent a few days back [2,3]. > > Probably the GPMC driver should go into a slightly different place than > SDRC/EMIF. > > GPMC is actually a general-purpose parallel bus driver. It's used to > interface Ethernet controllers, UARTs, FPGAs, NAND/NOR flash, SRAM, etc. > It cannot be used to control DRAM, at least not without a separate DRAM > controller chip. > > SDRC/EMIF are both DRAM controllers. That's all they do. They can't be > used to control anything else. They implement DRAM refresh, etc. The LPDDR2 spec does consider as well NVM (Non Volatile Memory), so I think we should stick to driver/memory for EMIF. > So perhaps something like drivers/memory/dram/ for the SDRAM controllers, > and maybe drivers/memory/ for the GPMC? In fact Felipe was considering something else for that kind of general purpose bus driver like GMPC, C2C and LLI... ... But I do not remember the name :-) Regards, Benoit