From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932595Ab2DMNRF (ORCPT ); Fri, 13 Apr 2012 09:17:05 -0400 Received: from kamaji.grokhost.net ([87.117.218.43]:38046 "EHLO kamaji.grokhost.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756664Ab2DMNRB (ORCPT ); Fri, 13 Apr 2012 09:17:01 -0400 Message-ID: <4F882745.4080301@bootc.net> Date: Fri, 13 Apr 2012 14:16:53 +0100 From: Chris Boot User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:12.0) Gecko/20120410 Thunderbird/12.0 MIME-Version: 1.0 To: "Nicholas A. Bellinger" CC: linux1394-devel@lists.sourceforge.net, target-devel@vger.kernel.org, linux-kernel@vger.kernel.org, agrover@redhat.com, clemens@ladisch.de, stefanr@s5r6.in-berlin.de, Christoph Hellwig Subject: Re: [PATCH v3 00/11] firewire-sbp-target: FireWire SBP-2 SCSI target References: <1329317248-94128-1-git-send-email-bootc@bootc.net> <1334154043-69076-1-git-send-email-bootc@bootc.net> <1334286222.3137.4877.camel@haakon2.linux-iscsi.org> In-Reply-To: <1334286222.3137.4877.camel@haakon2.linux-iscsi.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 13/04/2012 04:03, Nicholas A. Bellinger wrote: > On Wed, 2012-04-11 at 15:20 +0100, Chris Boot wrote: >> The FireWire SBP-2 Target is a driver for using an IEEE-1394 connection >> as a SCSI transport. This module uses the SCSI Target framework to >> expose LUNs to other machines attached to a FireWire bus, in effect >> acting as a FireWire hard disk similar to FireWire Target Disk mode on >> many Apple computers. >> >> Sorry this latest revision has been a long time coming. I was trying to >> chase down a crashing bug (but haven't been able to replicate it), changed >> my mind about a large portion of the code twice, and life got in the way as >> well! >> > Some very nice work to make this all go Chris.. 8-) > > Thanks again btw for your target_core_mod patches along the way to v3! No problem, it's been a very useful learning experience and I'm really glad I did it! :-) >> Changes in v3: >> * Updates for target framework API changes >> * Attempt to make headers self-contained >> * Remove bad use of atomics and memory barriers >> * Rework use of locking >> * Use system workqueues >> * Wrap fw_run_transaction() to retry failed transactions >> * Coding style fixes >> * Fix a few bugs >> * Overhaul sbp_rw_data() >> * Overhaul target fetch agent >> > So I've merged a squashed version this series from: > > https://github.com/bootc/Linux-SBP-2-Target.git patch-v3 > > into lio-core/master, and have now pushed to k.o upstream Thanks! > This looks to me like a reasonable candidate for a v3.5 mainline merge, > so we need to go ahead and get this into target-pending.. Also, thanks > for getting Stefan's ACK's here on the drivers/firmware/ specific > changes.. > > So for new fabric drivers (as discused with Sebastian and usb-gadget > recently) that the target team has been enforcing that new fabric > modules convert to use a single source / header file for readability and > maintainability purposes. > > It would be great if you can publish one more branch (no need to re-post > the full diff) that takes your patch-v3 down to a single .c/.h file. > Otherwise, I'm fine to take the 15 minutes to do this conversion ahead > of dropping into target-pending for the sunday night linux-next build. I'll get onto it over the weekend, I hope. I assume in this case I just stick it all in drivers/target/ instead of having a sbp/ directory underneath that? Cheers, Chris