From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751193Ab2DPGH4 (ORCPT <rfc822;w@1wt.eu>);
	Mon, 16 Apr 2012 02:07:56 -0400
Received: from wolverine02.qualcomm.com ([199.106.114.251]:38907 "EHLO
	wolverine02.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750788Ab2DPGHy (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 16 Apr 2012 02:07:54 -0400
X-IronPort-AV: E=McAfee;i="5400,1158,6681"; a="179647274"
X-IronPort-AV: E=Sophos;i="4.75,426,1330934400"; 
   d="scan'208";a="120384488"
Message-ID: <4F8BB735.4040409@qca.qualcomm.com>
Date: Mon, 16 Apr 2012 09:07:49 +0300
From: Kalle Valo <kvalo@qca.qualcomm.com>
User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.28) Gecko/20120313 Thunderbird/3.1.20
MIME-Version: 1.0
To: Jesper Juhl <jj@chaosbits.net>
CC: <linux-wireless@vger.kernel.org>, <netdev@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, Robert Love <rlove@google.com>,
        "John W. Linville" <linville@tuxdriver.com>,
        ath6kl-devel <ath6kl-devel@qualcomm.com>
Subject: Re: [PATCH] ath6kl: fix memory leak in ath6kl_fwlog_block_read()
References: <alpine.LNX.2.00.1204112239070.2137@swampdragon.chaosbits.net>
In-Reply-To: <alpine.LNX.2.00.1204112239070.2137@swampdragon.chaosbits.net>
Content-Type: text/plain; charset="ISO-8859-1"
Content-Transfer-Encoding: 7bit
X-Originating-IP: [172.30.39.5]
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 04/11/2012 11:41 PM, Jesper Juhl wrote:
> If, in
> drivers/net/wireless/ath/ath6kl/debug.c::ath6kl_fwlog_block_read(),
> the call to wait_for_completion_interruptible() returns -ERESTARTSYS
> then we'll return without freeing the (as yet unused) memory we
> allocated for 'buf' - thus leaking it.
> 
> Signed-off-by: Jesper Juhl <jj@chaosbits.net>

Thanks, applied to ath6kl.git.

Kalle