From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754718Ab2DPTxW (ORCPT ); Mon, 16 Apr 2012 15:53:22 -0400 Received: from mail-ob0-f174.google.com ([209.85.214.174]:59875 "EHLO mail-ob0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752861Ab2DPTxU (ORCPT ); Mon, 16 Apr 2012 15:53:20 -0400 Message-ID: <4F8C78AC.8000202@landley.net> Date: Mon, 16 Apr 2012 14:53:16 -0500 From: Rob Landley User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.27) Gecko/20120216 Thunderbird/3.1.19 MIME-Version: 1.0 To: richard -rw- weinberger CC: H Hartley Sweeten , Linux Kernel , "linux-doc@vger.kernel.org" Subject: Re: [PATCH] Documentation: remove 'linux' from dontdiff file References: <201204131552.03079.hartleys@visionengravers.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/13/2012 06:09 PM, richard -rw- weinberger wrote: > On Sat, Apr 14, 2012 at 1:06 AM, H Hartley Sweeten > wrote: >> Hmm.. So we are suppressing an entire branch of the directory tree (a >> fairly major one at that) for one file? >> > > No, we need a better solution. > Your patch replaces a regression with another one... Could somebody explain the purpose of this file to me? According to SubmittingPatches: > To create a patch for multiple files, you should unpack a "vanilla", > or unmodified kernel source tree, and generate a diff against your > own source tree. For example: > > MYSRC= /devel/linux-2.6 > > tar xvfz linux-2.6.12.tar.gz > mv linux-2.6.12 linux-2.6.12-vanilla > diff -uprN -X linux-2.6.12-vanilla/Documentation/dontdiff \ > linux-2.6.12-vanilla $MYSRC > /tmp/patch > > "dontdiff" is a list of files which are generated by the kernel during > the build process, and should be ignored in any diff(1)-generated > patch. The "dontdiff" file is included in the kernel tree in > 2.6.12 and later. For earlier kernel versions, you can get it > from . Allowing a vmlinux equivalent in there would produce "binary files differ", which is noise but not a regression. (The resulting patch wouldn't functionally differ when applied.) If it's really bothersome, possibly that hunk should have instructions that you should compare against a _clean_ tree you've done "make distclean" on? Rob -- GNU/Linux isn't: Linux=GPLv2, GNU=GPLv3+, they can't share code. Either it's "mere aggregation", or a license violation. Pick one.