From: Mark Lord <kernel@teksavvy.com>
To: John Stultz <john.stultz@linaro.org>
Cc: richard -rw- weinberger <richard.weinberger@gmail.com>,
Linux Kernel <linux-kernel@vger.kernel.org>,
rtc-linux@googlegroups.com,
Alessandro Zummo <a.zummo@towertech.it>,
Greg Kroah-Hartman <greg@kroah.com>,
stable@vger.kernel.org
Subject: Re: [REGRESSION] rtc/interface.c: kills suspend-to-ram
Date: Mon, 16 Apr 2012 22:27:08 -0400 [thread overview]
Message-ID: <4F8CD4FC.6020006@teksavvy.com> (raw)
In-Reply-To: <4F8C76AA.4050608@linaro.org>
On 12-04-16 03:44 PM, John Stultz wrote:
> On 04/16/2012 07:23 AM, richard -rw- weinberger wrote:
>> On Mon, Apr 16, 2012 at 3:55 PM, Mark Lord<kernel@teksavvy.com> wrote:
>>> Speaking of which -- that batch of RTC updates is riddled with bugs.
>>> For example, this beauty from rtc-mpc5121.c in the same update:
>>>
>>> ...
>>> rtc->rtc = rtc_device_register("mpc5200-rtc",&op->dev,
>>> &mpc5200_rtc_ops, THIS_MODULE);
>>> ...
>>>
>>> rtc->rtc->uie_unsupported = 1; //<<<< Ooops NULL pointer>>>>
>>>
>>> if (IS_ERR(rtc->rtc)) { //<<<< this needs to be earlier>>>>
>>> err = PTR_ERR(rtc->rtc);
>>> goto out_free_irq;
>>> }
>>> ...
>>>
>>>
>
> Thanks for noticing this and CC'ing me. I'll spin up a fix promptly for review.
> -john
Yeah. My apologies for being so harsh there.
At least the fix is easy enough.
Cheers!
next prev parent reply other threads:[~2012-04-17 2:27 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-16 4:36 [REGRESSION] rtc/interface.c: kills suspend-to-ram Mark Lord
2012-04-16 13:55 ` Mark Lord
2012-04-16 14:23 ` richard -rw- weinberger
2012-04-16 15:42 ` Mark Lord
2012-04-16 15:49 ` richard -rw- weinberger
2012-04-16 15:57 ` Mark Lord
2012-04-16 19:45 ` John Stultz
2012-04-16 21:43 ` John Stultz
2012-04-17 2:30 ` Mark Lord
2012-04-17 5:13 ` John Stultz
2012-04-17 12:51 ` Mark Lord
2012-04-17 20:11 ` Mark Lord
2012-04-17 20:12 ` Mark Lord
2012-04-17 23:02 ` John Stultz
2012-04-18 1:29 ` Mark Lord
2012-04-18 18:29 ` John Stultz
2012-04-27 14:33 ` Mark Lord
2012-04-27 19:22 ` John Stultz
2012-04-16 19:44 ` John Stultz
2012-04-17 2:27 ` Mark Lord [this message]
2012-04-16 14:26 ` [rtc-linux] " Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F8CD4FC.6020006@teksavvy.com \
--to=kernel@teksavvy.com \
--cc=a.zummo@towertech.it \
--cc=greg@kroah.com \
--cc=john.stultz@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=richard.weinberger@gmail.com \
--cc=rtc-linux@googlegroups.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox